Mantis Bugtracker
  

Viewing Issue Advanced Details Jump to Notes ] View Simple ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0003475 [Squeak] Compiler minor always 04-17-06 20:17 04-26-06 11:14
Reporter DF View Status public  
Assigned To
Priority normal Resolution fixed Platform
Status closed   OS
Projection none   OS Version
ETA none Fixed in Version 3.9 Product Version 3.9
  Product Build
Summary 0003475: Modifications to make MethodWrappers work in 3.9
Description The extension of MethodNode>>generateMethodWrapper:trailer: doesn't work in Squeak 3.9.
I fixed it with a refactoring of MethodNode>>generate: (included in the attached MC Compiler package).
The modifications in MethodWrappers are included in a change set, because I couldn't load new versions of this package (MC complains with an error on the instance variables of the class MwCompileMethod).
With this modifications the tests pass, but I noticed that the tests doesn't do a correct clean-up of MwClassA and MwClassB in case of failures.
Steps To Reproduce
Additional Information
Attached Files  MW39fixes.zip [^] (125,284 bytes) 04-17-06 20:17

- Relationships

- Notes
(0004757 - 1029 - 1231 - 1363 - 1363 - 1363 - 1363)
DF
04-19-06 06:30

Hi, I have uploaded a new MC package version of MethodWrappers fixed to work with 3.9 in the MC HTTP repository for the codeCoverage project.
To download it from MC:
MCHttpRepository
    location: 'http://www.squeaksource.com/codeCoverage' [^]
    user: ''
    password: ''

And then install Compiler-DF.5.mcz and MethodWrappers-DF.7.mcz

Changes:

MethodWrappers
-All sends to #tempNameCache: was removed
-MwMethodWrapper implements #asClassDescription to store a correct definition of the class in Monticello
-MwMethodWrapper>>#tempNameCahe: removed
-The extension of MethodNode was removed. Now is implemented using a refactorized MethodNode so #generate:
and MethodWrappers use the same implementation (in the previous version MethodWrappers uses a copy&pasted version of #generate: just to change the class of the compiled method)
The drawback: it requires a different version of the Compiler package

Compiler
-#generate: implemented as:
generate: trailer
self generateWith: trailer using: CompiledMethod
 
(0004814 - 83 - 95 - 95 - 95 - 95 - 95)
MarcusDenker
04-26-06 11:14

-> image changes are in 3.9a
-> MW code is on SqueakSource (Project MethodWrapper)
 

- Issue History
Date Modified Username Field Change
04-17-06 20:17 DF New Issue
04-17-06 20:17 DF Status new => assigned
04-17-06 20:17 DF Assigned To  => KenCausey
04-17-06 20:17 DF File Added: MW39fixes.zip
04-17-06 20:24 KenCausey Assigned To KenCausey =>
04-17-06 20:24 KenCausey Status assigned => new
04-17-06 20:24 KenCausey Category Any => Compiler
04-19-06 04:22 DF Issue Monitored: DF
04-19-06 06:30 DF Note Added: 0004757
04-26-06 11:14 MarcusDenker Status new => closed
04-26-06 11:14 MarcusDenker Note Added: 0004814
04-26-06 11:14 MarcusDenker Resolution open => fixed
04-26-06 11:14 MarcusDenker Fixed in Version  => 3.9


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
49 total queries executed.
35 unique queries executed.
Powered by Mantis Bugtracker