0005568: CroquetParticipantWithMenu>>mouseEnter: doesn't test for null openAL

Viewing Issue Advanced Details [ Jump to Notes ]

[ View Simple ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0005568

[Croquet] Hedgehog

major

always

12-04-06 03:54

12-04-06 04:33

Reporter

howardstearns

View Status

public

Assigned To

Priority

normal

Resolution

open

Platform

Status

new

Projection

none

OS Version

ETA

none

Product Build

Summary

0005568: CroquetParticipantWithMenu>>mouseEnter: doesn't test for null openAL

Description

It is:
mouseEnter: evt
    super mouseEnter: evt.
    harness ifNotNil: [
        harness openAL isCurrent ifFalse: [
            harness makeOpenALCurrent.
        ].
    ].
But harness openAL can be nil if the machine doesn't have the right hardware/software setup, in which case we get an error. In general, we test for openAL being nil, and we should here, too:

Steps To Reproduce

Additional Information

Fix is:
CroquetParticipantWithMenu>>mouseEnter: evt
    super mouseEnter: evt.
    harness ifNotNil: [
        harness openAL ifNotNilDo: [:oal | oal isCurrent ifFalse: [harness makeOpenALCurrent].
        ].
    ].

Attached Files

Relationships

Notes
(0008532 - 258 - 300 - 300 - 300 - 300 - 300) howardstearns 12-04-06 04:33	Well, probably not "major". We ought to decide someday what that means. For example, in some places "major" means you end up in the debugger, which is the case here. But there's a lot of other cases where that happens, which we haven't designated "major."

Issue History
Date Modified	Username	Field	Change
12-04-06 03:54	howardstearns	New Issue
12-04-06 04:33	howardstearns	Note Added: 0008532

Mantis 1.0.8[^]

31 total queries executed.
26 unique queries executed.