Mantis Bugtracker
  

Viewing Issue Advanced Details Jump to Notes ] View Simple ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0005851 [Squeak] Kernel feature always 01-29-07 01:58 04-18-10 21:59
Reporter Keith_Hodges View Status public  
Assigned To Keith_Hodges
Priority normal Resolution open Platform
Status closed   OS
Projection tweak   OS Version
ETA none Fixed in Version 3.10.2bc Product Version 3.10
  Product Build
Summary 0005851: Refactor SmalltalkImage saveAs
Description Refactor SmalltalkImage-#saveAs to pull out the code that actually saves the image under a new name, into #saveAs: newName

Refactor some other methods that duplicate the use of the same code, to use #saveAs:
Steps To Reproduce
Additional Information
Attached Files  SmalltalkImage.1.cs [^] (1,844 bytes) 01-29-07 01:58
 SmalltalkImage.2.cs [^] (2,322 bytes) 02-14-07 12:13
 SmalltalkImage-M5851.3.cs [^] (2,314 bytes) 06-10-08 04:34
 M5851-SmalltalkImage-saveAs.1.cs [^] (2,434 bytes) 12-16-08 18:51

- Relationships
child of 0007423new  Fixes included in Level Playing Field 

- Notes
(0009762 - 76 - 76 - 76 - 76 - 76 - 76)
Keith_Hodges
02-14-07 12:14

SmalltalkImage.2.cs ensures that the resuming flag is returned from #saveAs:
 
(0012290 - 84 - 116 - 116 - 116 - 116 - 116)
matthewf
06-10-08 04:35

"fix begin"
Installer mantis bug: 5851 fix: 'SmalltalkImage-M5851.3.cs'.
"fix end"
 
(0012291 - 58 - 58 - 58 - 58 - 58 - 58)
matthewf
06-10-08 04:35

SmalltalkImage-M5851.3.cs removes an underscore assignment
 
(0012851 - 183 - 207 - 207 - 207 - 207 - 207)
Keith_Hodges
12-16-08 17:39
edited on: 12-16-08 18:52

Currently the code doesnt work if the given filename doesnt have .image on the end, perhaps we should ensure that it does, or append it.

Fixed in M5851-SmalltalkImage-saveAs.1.cs

 
(0013123 - 732 - 846 - 846 - 951 - 951 - 951)
nicolas cellier
05-11-09 20:54
edited on: 05-11-09 21:31

Hi Keith, concerning .image extension, I don't think you fixed all the broken code...

For example, you want to save a Squeak3.10.2-7179-basic.image:
Let's debug:
SmalltalkImage current saveAs

From #getFileNameFromUser you enter 'Squeak3.10.2-7179-basic' (remove the .image).
Now you execute
FileDirectory default fileOrDirectoryExists: (self fullNameForImageNamed: newName) -> false
Surprise, (self fullNameForImageNamed: newName) -> Squeak3.10.image

So, you won't save on the image name you did ask for.
And the fix you proposed won't fix this one...
We must either install your workaround also in #getFileNameFromUser
Or maybe we should better fix #fullNameForImageNamed:/#fullNameForChangesNamed:

See 0007351

 
(0013413 - 44 - 44 - 44 - 149 - 149 - 149)
nicolas cellier
11-29-09 19:35

This was superseded by 0007351 in Squeak trunk
 

- Issue History
Date Modified Username Field Change
01-29-07 01:58 Keith_Hodges New Issue
01-29-07 01:58 Keith_Hodges File Added: SmalltalkImage.1.cs
01-29-07 01:59 Keith_Hodges Note Added: 0009235
01-30-07 03:05 Keith_Hodges Note Edited: 0009235
02-03-07 02:42 Keith_Hodges Issue Monitored: Keith_Hodges
02-14-07 12:13 Keith_Hodges File Added: SmalltalkImage.2.cs
02-14-07 12:14 Keith_Hodges Note Added: 0009762
02-14-07 12:15 Keith_Hodges Note Edited: 0009235
06-10-08 04:34 matthewf File Added: SmalltalkImage-M5851.3.cs
06-10-08 04:35 matthewf Note Added: 0012290
06-10-08 04:35 matthewf Note Added: 0012291
12-16-08 17:36 Keith_Hodges Assigned To  => Keith_Hodges
12-16-08 17:36 Keith_Hodges Status new => acknowledged
12-16-08 17:36 Keith_Hodges Projection none => tweak
12-16-08 17:36 Keith_Hodges Fixed in Version  => 3.10.2bc
12-16-08 17:39 Keith_Hodges Note Added: 0012851
12-16-08 18:51 Keith_Hodges File Added: M5851-SmalltalkImage-saveAs.1.cs
12-16-08 18:51 Keith_Hodges Note Edited: 0009235
12-16-08 18:52 Keith_Hodges Note Edited: 0012851
12-16-08 19:27 Keith_Hodges Severity trivial => feature
01-09-09 23:30 Keith_Hodges Note Deleted: 0009235
01-09-09 23:31 Keith_Hodges Status acknowledged => resolved
05-11-09 20:54 nicolas cellier Note Added: 0013123
05-11-09 21:31 nicolas cellier Note Edited: 0013123
11-28-09 02:26 matthewf Relationship added child of 0007423
11-29-09 19:35 nicolas cellier Note Added: 0013413
04-18-10 21:59 andreas Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
98 total queries executed.
48 unique queries executed.
Powered by Mantis Bugtracker