|Anonymous | Login||09-24-2020 15:54 UTC|
|Main | My View | View Issues | Change Log | Docs|
|Viewing Issue Advanced Details [ Jump to Notes ]||[ View Simple ] [ Issue History ] [ Print ]|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0007128||[Squeak Packages] Squeak-Dev||minor||always||07-18-08 21:50||07-21-08 18:33|
|Reporter||stan shepherd||View Status||public|
|Assigned To||Damien Cassou|
|Summary||0007128: Saving preferences creates obsolete classes|
The attached test case fails in a new sq3.10.1-7175dev08.06.1 image. (or
PreferenceBrowser new saveSelected.
self should: [SystemNavigation default obsoleteBehaviors size = 0]
SystemNavigation default obsoleteBehaviors inspect actually
has 400+ entries.
Most of the entries are BooleanPreferenceView class or PBBooleanPreferenceView
class, but also other classes such as Scrollbar, UIThemeStandardSqueak, ...
It happens in
"Save the current list of Preference settings as the user's personal choices"
to:self dictionaryOfPreferences deepCopy
I think during the deepCopy.
|Steps To Reproduce|
|Additional Information||Testcase attached|
|Attached Files||TestPreferenceSaving.st [^] (482 bytes) 07-18-08 21:50|
(0012389 - 118 - 118 - 118 - 118 - 118 - 118)
|I don't have enough knowledge to fix it. If you know of somebody who can please tell me. If you can fix it, please do.|
(0012390 - 123 - 123 - 123 - 123 - 123 - 123)
|I think I incorrectly posted this to Squeak-Dev, while it should be in the main Squeak branch. Please can an admin move it?|
(0012391 - 546 - 612 - 612 - 612 - 612 - 612)
I have noticed also that saving preferences to disk and restoring them from the pref browser doesn't work.
I noticed this a fresh july 2008 squeak-dev.
I haven't yet checked in a basic 3.10.2 yet.
It would seem to me that this is probably a general bug rather than specific to squeak-dev.
Changing the status of the report requires someone with editing privs for squeak packages. I have edit privs but only for squeak reports they don't seem to extend to other catagories.
Yoours in curiosity and service, -Jerome Peace
(0012394 - 306 - 354 - 354 - 354 - 354 - 354)
the bug was already in 3.8.
As stan detected deepCopy is responsible for the copy being too deep.
Replacing deepCopy with veryDeepCopy does solve the problem.
veryDeepCopy is robust to cyclic references and knows better where to stop.
deepCopy is something we should get rid of IMO...
(0012395 - 232 - 268 - 268 - 268 - 268 - 268)
I had thought that the old preference browser/panel was able to save and restore preferences ok. At least I remember using it in 3.9.
Is that correct? The deep copy problem only applies to the new browser?
(0012396 - 303 - 344 - 344 - 344 - 344 - 344)
I think the fact that deepCopy creates some clone does not prevent the feature to function correctly.
Though, creating those copies:
- is probably unintentional,
- is probably useless,
- is not very clean,
(might create obscur bugs if cloned class happened to change?),
- IMO should be corrected.
|07-18-08 21:50||stan shepherd||New Issue|
|07-18-08 21:50||stan shepherd||Status||new => assigned|
|07-18-08 21:50||stan shepherd||Assigned To||=> Damien Cassou|
|07-18-08 21:50||stan shepherd||File Added: TestPreferenceSaving.st|
|07-19-08 08:15||Damien Cassou||Note Added: 0012389|
|07-19-08 14:20||stan shepherd||Note Added: 0012390|
|07-19-08 17:11||wiz||Note Added: 0012391|
|07-19-08 21:16||nicolas cellier||Note Added: 0012394|
|07-19-08 21:57||wiz||Note Added: 0012395|
|07-21-08 18:33||nicolas cellier||Note Added: 0012396|
| Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
58 total queries executed.|
41 unique queries executed.