Mantis Bugtracker
  

Viewing Issue Advanced Details Jump to Notes ] View Simple ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007634 [Squeak] Tools minor always 05-06-11 10:41 05-06-11 21:37
Reporter FrankShearar View Status public  
Assigned To FrankShearar
Priority normal Resolution fixed Platform
Status resolved   OS
Projection none   OS Version
ETA none Fixed in Version Product Version trunk
  Product Build
Summary 0007634: Cannot revert a class comment
Description Find a class with a class comment. Edit the comment. Click "versions". Revert to an earlier version.

"NonBooleanReceiver: proceed for truth." because instvar meta in ChangeRecord>>methodClass has as its value the class you're currently editing, rather than a boolean!
Steps To Reproduce
Additional Information
Attached Files

- Relationships

- Notes
(0014091 - 397 - 563 - 563 - 563 - 563 - 563)
FrankShearar
05-06-11 11:47

ClassCommentVersionBrowser>>#scanVersionsOf: says this:

  self addItem:
    (ChangeRecord new file: file position: position type: #classComment
      class: class name category: nil meta: class stamp: stamp)

There are two possible solutions: force meta to be "class" or "class class", or change ChangeRecord>>#methodClass to say

  meta ifTrue: [ ^ methodClass class ].
  ^ methodClass.
 
(0014092 - 58 - 58 - 224 - 224 - 224 - 224)
FrankShearar
05-06-11 20:16

http://source.squeakfoundation.org/inbox/Tools-fbs.350.mcz [^]
 
(0014094 - 31 - 31 - 31 - 31 - 31 - 31)
FrankShearar
05-06-11 21:37

Nicolas Cellier added to Trunk.
 

- Issue History
Date Modified Username Field Change
05-06-11 10:41 FrankShearar New Issue
05-06-11 11:47 FrankShearar Note Added: 0014091
05-06-11 11:50 FrankShearar Status new => assigned
05-06-11 11:50 FrankShearar Assigned To  => FrankShearar
05-06-11 20:16 FrankShearar Note Added: 0014092
05-06-11 20:16 FrankShearar Status assigned => feedback
05-06-11 21:37 FrankShearar Status feedback => resolved
05-06-11 21:37 FrankShearar Resolution open => fixed
05-06-11 21:37 FrankShearar Note Added: 0014094


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
44 total queries executed.
33 unique queries executed.
Powered by Mantis Bugtracker