Mantis - Squeak
Viewing Issue Advanced Details
1407 System tweak always 07-02-05 03:05 01-18-06 23:48
masm  
ohshima  
normal  
closed 3.8  
fixed  
none    
none 3.9  
0001407: FileStream>isSourceFileSuffix: and senders
Timothy Rowledge <tim@sumeru.stanford.edu>:

I notice that isSourceFileSuffix includes '*' as an option and yet
three of the four senders use
(self isSourceFileSuffix: foo) or:[foo = '*'] which seems a little
confused.

Someone that knows what is truly intended here might like to check on
this.

tim
 isSourceFileSuffix-M1407.1.cs.gz [^] (337 bytes) 09-16-05 01:09

Notes
(0002652)
tim   
09-15-05 04:46   
This is still ugly in the 3.8 final. My thought is that the check for '*' in the isSourceSuffix method should be dropped since it clearly isn't clean.
(0002653)
tim   
09-15-05 04:49   
Reminder sent to: ohshima

Yoshi, could you take a quick look at this? I think the answer is imple but you must have had a good reason for writing the method as it is now.

tim
(0002656)
ohshima   
09-15-05 08:01   
Ah, I haven't though about the implication if we drop it from isSourceFileSuffix:, but I think it is ok.

  m17n codebase is derived from 3.2 and modified 3.6. For these images, including '*' was simply compatible with the official release.

(cf. hg 8/3/2000 18:13 FileStream class isSourceFileSuffix:)

Just edit it away and see if somebody complains.
(0002666)
tim   
09-16-05 01:10   
OK, the obvious trivial change is in the attached changeset. I couldn't see anything break.
(0002734)
MarcusDenker   
09-29-05 18:10   
changeset needs to be added to 3.9.
(0003543)
MarcusDenker   
01-18-06 23:48   
will be in 6716