0001454: [Fix] Add vertex handle doesn't work for arrows.

Mantis - Squeak

Viewing Issue Advanced Details

ID:

Category:

Severity:

Reproducibility:

Date Submitted:

Last Update:

1454

Morphic

tweak

always

07-13-05 07:24

02-15-06 19:01

Reporter:

wiz

Platform:

Assigned To:

OS:

Priority:

normal

OS Version:

Status:

closed

Product Version:

Product Build:

Resolution:

fixed

Projection:

none

ETA:

none

Fixed in Version:

3.9

Summary:

0001454: [Fix] Add vertex handle doesn't work for arrows.

Description:

Go to objects. Get an arrow. Add handles.
The triangle does not add a vertex. Huh?

Steps To Reproduce:

Additional Information:

Polygon class ArrowPrototype goes thru pains to make the arrow inflexible. This confuses the users who expect the add vertex triangle to work as normal.

This changeset comments out the old code and reverts to the more usual behavior.

Ideally someone should do a use test to see which way is best for users. Realistically someone should choose whether this is a bug and fix it or not.

Historical notes: the routines affected were changed in sept-oct 2002 by sw.

This changeset is offered to give the maintainers a choice and to give the users who don't like the current behavior a remedy."!

!PolygonMorph methodsFor: 'editing' stamp: 'wiz 7/13/2005 00:11'!
newVertex: ix event: evt fromHandle: handle
    "Insert a new vertex and fix everything up!! Install the drag-handle of the new vertex as recipient of further mouse events."

    | pt |
    "(self hasProperty: #noNewVertices) ifFalse:
        [pt _ evt cursorPoint.
        self setVertices: (vertices copyReplaceFrom: ix + 1 to: ix with: (Array with: pt)).
        evt hand newMouseFocus: (handles at: ((ix + 1) * 2) - 1)]"
    "modified to remove now vestigial test. see PolygonMorph class>>arrowprototype"
    pt _ evt cursorPoint.
    self setVertices: (vertices copyReplaceFrom: ix + 1 to: ix with: (Array with: pt)).
    evt hand newMouseFocus: (handles at: ((ix + 1) * 2) - 1)! !

Relationships

duplicate of

0001448

closed

Can't add point to line with arrow

Attached Files:

arrowPrototypeFix-wiz.1.cs.gz [^] (793 bytes) 07-13-05 07:24

arrowPrototypeFix-wiz.2.cs.gz [^] (1,063 bytes) 07-13-05 07:44

Notes