Mantis - Squeak
Viewing Issue Advanced Details
1493 Graphics minor always 07-19-05 18:49 07-22-05 22:22
ducasse  
 
normal  
closed  
fixed  
none    
none 3.9  
0001493: [BUG] in color (Color r: 1 g:0 b:0) * #(1 1 1) -> DNU
in the comment of Color we read that we can * a color by an array to get

    self assert: (Color r: 1 g:0 b:0) * #(1 1 1) = Color red

But (Color r: 1 g:0 b:0) * #(1 1 1) raises an error
 ColorTimeArray-fbs.cs.gz [^] (747 bytes) 07-19-05 18:54

Notes
(0001842)
KenCausey   
07-19-05 18:50   
"Frank Shearar" <Frank.Shearar@rnid.org.uk>:

"Hm yes; Color>>* has a method pattern (I can't recall the proper name?) of

* aNumber
    "Answer this color with its RGB multiplied by the given number. "
    "(Color brown * 2) display"

and dates from 1997/02/11 - it looks like the comment is just plain wrong?

I don't mind writing a fix, if someone tells me which solution to use: fix the comment, or fix the code (and of course write a test)."
(0001843)
KenCausey   
07-19-05 18:53   
"Frank Shearar" <Frank.Shearar@rnid.org.uk>:

"Why work when I can procrastinate & work on Squeak?"

Changeset attached.
(0001903)
MarcusDenker   
07-22-05 22:21   
tested the fix: Solves the problem
(0001904)
MarcusDenker   
07-22-05 22:21   
in 3.9a