Mantis - Squeak
Viewing Issue Advanced Details
1618 Kernel minor always 08-05-05 18:16 08-05-05 18:25
KenCausey  
 
normal  
new  
open  
none    
none  
0001618: [ENH] ParagraphEditor-iSearch-rkris
rkris@kriyative.net:

"Change Set: ParagraphEditor-iSearch-rkris
Date: 28 July 2004
Author: Ram Krishnan

Adds incremental search (similar to emacs but forward search only) to
ParagraphEditor. This changeset remaps the Ctl-S key, which used to
invoke the #search: selector, to the #incrementalSearch: selector. While
in the incrementalSearch mode, Ctl-W can be used to extend the search
term and Backspace to shorten it. This changeset has only been tested
with Squeak3.7. It will fail in Squeak3.6 as there seem to be some
conflicting changes in ParagraphEditor between the two revisions."
 ParagraphEditor-iSearch-rkris.cs.gz [^] (4,652 bytes) 08-05-05 18:16
 ParagraphEditor-iSearch-rkris.2.cs.gz [^] (5,152 bytes) 08-05-05 18:24

Notes
(0002160)
KenCausey   
08-05-05 18:20   
Samuel Tardieu <sam@rfc1149.net>:

"The search works fine. However, I find that a non-match is misleading.
If for example you search for "abd" in a text containing "xxxxabcxxx",
"a" will be first highlighted, then "ab", then nothing (which is
not distinct from the default non-search mode). "ab" should be
highlighted in another color (red?) if possible, and no character should
be added to the search string when there are no matches."
(0002161)
KenCausey   
08-05-05 18:22   
rkris@kriyative.net:

"Thanks for the feedback. The non-match behavior is definitely
misleading. I've pushed another changeset to the squeak-dev list which
should address that issue. I also briefly looked at how to visually
indicate whether or not a ParagraphEditor instance is in iSearch mode.
That will require some changes to the class NewParagraph."

"Change Set: ParagraphEditor-iSearch-rkris
Date: 14 August 2004
Author: Ram Krishnan

Adds incremental search (similar to emacs but forward search only) to
ParagraphEditor. This changeset remaps the Ctl-S key, which used to
invoke the #search: selector, to the #incrementalSearch: selector. While
in the incrementalSearch mode, Ctl-W can be used to extend the search
term and Backspace to shorten it. This changeset has only been tested
with Squeak3.7. It will fail in Squeak3.6 as there seem to be some
conflicting changes in ParagraphEditor between the two revisions.

This changeset improves the behavior to be more compatible with the
Emacs incremental-search functionality, such as:

    * The current `point' is saved when entering incremental search and
restored when exiting via Ctl-G
    
    * A mismatch leaves the point and mark at the last matched region of
text"

(attaching ParagraphEditor-iSearch-rkris.2.cs.gz)
(0002162)
KenCausey   
08-05-05 18:25   
I seperately loaded each changeset successfully into 3.8-6665-basic but did not test further.