Mantis - Squeak
Viewing Issue Advanced Details
1802 Kernel text always 09-16-05 10:46 10-01-05 22:04
laza  
 
low  
closed 3.9  
fixed  
none    
none 3.9  
0001802: Add a warning hint to Delay comment
I think adding andreas comment from 0001644 to the Delay comment is a good idea:

"A word of advice:
This is THE highest priority code which is run in Squeak, in other words it is time-critical. The speed of this code is critical for accurate responses, it is critical for network services, it affects every last part of the system.

In short: Don't fix it if it ain't broken! This code isn't supposed to be beautiful, it's supposed to be fast! The reason for duplicating code is to make it fast. The reason for not using ifNil:[]ifNotNil:[] is that the compiler may not inline those. Since the effect of changes are VERY hard to predict it is best to leave things as they are for now unless there is an actual need to change anything."
related to 0001644closed  [ENH] DelayRefactoring-st 

Notes
(0002681)
laza   
09-16-05 10:55   
Reminder sent to: andreas

Since you're the author of that text you might want to grant permission for its use or to tweak it a bit. :)
(0002684)
laza   
09-16-05 12:39   
Apperently there will be such a hint in the Delay comment with the next updates. See comment in 0001644 by Marcus.
(0002753)
ducasse   
10-01-05 22:03   
comment added in 3.9a script 4