Mantis - Squeak
Viewing Issue Advanced Details
2352 Morphic minor always 12-12-05 10:29 02-24-06 21:51
al  
 
normal  
closed 3.9  
6705 (or earlier) fixed  
none    
none 3.9  
0002352: FileListBrowser shows "changes" and "code" buttons twice
FileListBrowser, when pointed to a smalltalk code file, shows the "changes" and "code" buttons twice

Notes
(0003296)
tbn   
12-12-05 21:30   
Putting a halt into FileList2#updateButtonRow and inspecting
"self dynamicButtonServices" shows that ChangeSet and ChangeSorter
have registered for handling code files.

We should remove one.
(0003297)
tbn   
12-12-05 21:53   
Squeak 3.8#6665 looks ok, the bug is in 3.9#6705.

Looks like Andreas Raab (ar) moved class side code from ChangeSet to ChangeSorter. The old code (including file service registration) is still in ChangeSorter.
Either he forgot to remove it or is in the midst of a bigger refactoring.

I write him an e-mail to comment.
(0003298)
andreas   
12-12-05 22:24   
The problem is caused by installing two tool sets (duplicate services). Remove one and you'll be fine.
(0003309)
andreas   
12-13-05 02:10   
Actually, it might be good to implement the #services of the various tools depending on which tool set is installed, e.g., something like:

ChangeListPlus>>services
  ToolSet default == PlusTools ifFalse:[^#()].
  ... yaddaya ...
(0004067)
MarcusDenker   
02-24-06 21:51   
fixed in 7003