Mantis - Squeak
Viewing Issue Advanced Details
2512 Morphic major always 01-16-06 21:40 03-19-06 13:57
wiz  
 
normal  
closed 3.9  
fixed  
none    
none 3.9  
0002512: In 6713 Morphs dropped onto their viewers get deleted.
For this one.

Get an object (a polygon will do nicely.)

Using the halos open a veiwer for the polygon.

With the hand pick up the polygon.
 Move it over the viewer.
   And dropit.

Rather than returning to its spot it will disappear and so will its viewer.
This is just a flashier demonstration of the bug reported in Mantis 0001816.

The preferences have been set in 6713 to delete the morph w/o putting it in the trash.

Since a morph in the hand no longer remembers its former owner it will not return but be deleted instead.
related to 0001816closed  In 6690 morphs dropped onto objects window get a one way trip to the trash. 
 RejectedPolyDeleteFix-wiz.1.cs [^] (1,335 bytes) 01-25-06 05:18
 polygonFix-tak.cs [^] (1,634 bytes) 03-17-06 17:51

Notes
(0003599)
wiz   
01-23-06 06:43   
Another clue:

Polygons get deleted but RectangeMorphs and EllipseMorphs happliy return to their former position. I guess some morphs just take rejection better than others.

I'm now playing in Sq6717 but I don't think thats significant.

I know Polygons used to know what to do when rejected back in Sq 3.2 because I made puzzleboard there using polygons for piece and they worked fine.

Now I suspect grabing the polygon is not recording its former owner.
What's changed?

I check in 3.8from3.0 there everything worked as planed polygons and ellipses both return to former positions when rejected.
In 3.9from3.0 polygons got trashed when rejected. So the breakage is do to 3.8 development. I wonder where.

(0003625)
wiz   
01-25-06 05:25   
Found the problem.

From the preamble.

Polygons releaseCacheState whenever they change position.
The overide calls its super and the super(Morph) was changed in

 tak 1/12/2005 14:57 caching only in change set 6580changesFromSql38ToJa

While it might be wiser to make polygon cleverer because of the severity of the problem it seems fair to revert the fix until more thought can be put into polygon. I don't know what problem the original patch was suppose to solve.

So this and the previously reported bug 1816 are actually the same and this will remedy both.

Yours in service, -- Jerome Peace
(0004514)
tak   
03-17-06 17:57   
Surely, this bug is caused from my misunderstanding of Morphic. Proposed change set polygonFix-tak.cs fixes will solve the issue. Originally, my patch was for eliminating unexpected pointer when a project or a morph is saved into .pr or .morph file. Andreas Raab suggested me that #prepareToBeSaved is right place to do it.
(0004518)
wiz   
03-19-06 00:01   
Hi tak,

Thanks for your help and quick response. I looked a your changes and they should do the trick.

I tested to make sure polygons no longer get deleted (they don't). I didn't test the other aspect with change sets. i assume that works to your satisfaction.

Cheers -- Jerome Peace
(0004519)
wiz   
03-19-06 00:05   
Reminder sent to: user457

Hi Jaun,

This ones ready to go into an image. taks fix will work. If you are still busy with your move I suspect you can just ask Marcus to handle it.

Marcus will fix anything.
(0004524)
MarcusDenker   
03-19-06 13:57   
will be in 7013