Mantis - Squeak 3.8
Viewing Issue Advanced Details
3458 Kernel major always 04-11-06 23:01 04-25-06 14:22
andreas  
 
normal  
new 3.8  
open  
none    
none  
0003458: PositionableStream>>copyPreamble:from:at: broken
PositionableStream>>copyPreamble:from:at: uses the last occurance of the string "stamp:" in the 50-100 bytes before the source position to find the time stamp for a method. This will fail if the previous method uses the word "stamp:" and the current method doesn't actually have a time stamp. Observed (for example) in a setting where ClassDescription was moved in condenseSources and the input data looked like here:

' onFileNumber: 2 toFile: aFileStream) stamp: aStamp! !

!ClassDescription methodsFor: ''fileIn/Out''!
'

In the above, the first part is the last portion of ClassDescription>>putClassCommentToCondensedChangesFile: and the second part the actual preamble of ClassDescription>>reformatAll. Other places are affected by this issue as well in particular after condensing changes or sources.
 PositionableStream-copyPreamblefromat.st [^] (1,074 bytes) 04-12-06 01:45

Notes
(0004736)
andreas   
04-12-06 01:45   
The attached fix uses #backChunk to determine the preamble correctly.
(0004800)
MarcusDenker   
04-25-06 14:22   
added to 7025