Mantis - Squeak
Viewing Issue Advanced Details
3506 ToDo minor always 04-26-06 11:19 07-15-06 18:05
MarcusDenker  
 
normal  
closed 3.9  
fixed  
none    
none 3.9  
0003506: some _ wrongly converted to _
SystemNavigation default browseAllSelect: [:meth |
    meth literals anySatisfy: [:lit | lit class == Array and: [
        | todo found |
        todo := OrderedCollection withAll: lit.
        found := false.
        [found or: [todo isEmpty]] whileFalse: [
            | next |
            next := todo removeFirst.
            next class == Array ifTrue: [todo addAll: next].
            found := next isString and: [next includesSubString: ':=']].
        found]]]
 revertUnderscoreCvt-KR.cs [^] (3,648 bytes) 05-08-06 14:32

Notes
(0004821)
ducasse   
04-29-06 21:57   
where is the code?
What should I change
I looked at the implementors of
browseAllSelect: and I get

browseAllSelect: aBlock
    "Create and schedule a message browser on each method that, when used
    as the block argument to aBlock gives a true result. For example,
    SystemNavigation new browseAllSelect: [:method | method numLiterals >
    10]."
    ^ self
        browseMessageList: (self allMethodsSelect: aBlock)
        name: 'selected messages'


And the senders are also not that one.
(0004828)
MarcusDenker   
04-30-06 11:58   
you need to execute the code: it will show a handfull of methods with wrong conversions, these need to be fixed.
(0004892)
korakurider   
05-08-06 14:33   
fix for 3.9b-7029 is attached
(0005947)
MarcusDenker   
07-15-06 18:05   
7045