Mantis - Squeak
Viewing Issue Advanced Details
4609 Morphic minor always 08-20-06 00:47 04-18-10 22:07
wiz  
wiz  
normal  
closed 3.9  
fixed  
none    
none 3.10  
0004609: [Fix] Removal of ButtonPropertiesMorph left an unimplemented call.
The bug fix for Mantis 0000521 was the removal of ButtonPropertiesMorph

Current work on Mantis 0004544 shows that
AlignmentMorphBob1 called a method that was only implemented in the
ButtonPropertiesMorph.

 
The two removed routines are here so other eyes than mine can see.:

ButtonPropertiesMorph>>
acceptDroppingMorph: aMorph event: evt

    | handlerForDrops |

    handlerForDrops _ self valueOfProperty: #handlerForDrops ifAbsent: [
        ^super acceptDroppingMorph: aMorph event: evt
    ].
    (handlerForDrops acceptDroppingMorph: aMorph event: evt in: self) ifFalse: [
        aMorph rejectDropMorphEvent: evt. "send it back where it came from"
    ].

ButtonPropertiesMorph>>
wantsDroppedMorph: aMorph event: evt

    | handlerForDrops |

    handlerForDrops _ self valueOfProperty: #handlerForDrops ifAbsent: [
        ^super wantsDroppedMorph: aMorph event: evt
    ].
    ^handlerForDrops wantsDroppedMorph: aMorph event: evt in: self

BPMCleanup-wiz.1.cs removes them.

Yours in service, -- Jerome Peace
child of 0004544closed  In 7054 there are 194 unimplementedCalls including some that look like they might be important 
 BPMCleanup-wiz.1.cs [^] (759 bytes) 08-20-06 00:47
 7054 - 6665unimpAnnotedA-H.text [^] (3,382 bytes) 08-20-06 02:08

Notes
(0008311)
RalphJohnson   
11-18-06 01:28   
Shouldn't the resolution be changed to "fixed"?
(0008318)
wiz   
11-18-06 08:39   
Hi Ralph,

In general reporters don't have access to change the report status.

I enjoy the lack of authority or responsibility. Someone else needs to look at, judge, and bless the fix. That is a first guard for quality.

Sooner or later someone will get back into harvesting mode and update the status when they choose to harvest the fix. Till then it sits here as just a suggestion.

Though I take your comment as a compliment.

Yours in service, -Jerome Peace