Mantis - Squeak
Viewing Issue Advanced Details
4789 Kernel minor always 09-09-06 13:49 09-09-06 18:09
Krivanek  
 
normal  
new 3.10  
open  
none    
none  
0004789: [KernelImageOverride] TraitDescription logMethodSource:...
TraitDescription >> logMethodSource:forMethodWithNode:inCategory:withStamp:notifying:

original:

logMethodSource: aText forMethodWithNode: aCompiledMethodWithNode inCategory: category withStamp: changeStamp notifying: requestor
    | priorMethodOrNil newText |
    priorMethodOrNil := self compiledMethodAt: aCompiledMethodWithNode selector ifAbsent: [].
    newText _ ((requestor == nil or: [requestor isKindOf: SyntaxError]) not
                        and: [Preferences confirmFirstUseOfStyle])
            ifTrue: [aText askIfAddStyle: priorMethodOrNil req: requestor]
            ifFalse: [aText].
    aCompiledMethodWithNode method putSource: newText
        fromParseNode: aCompiledMethodWithNode node
        class: self category: category withStamp: changeStamp
        inFile: 2 priorMethod: priorMethodOrNil.

override:

logMethodSource: aText forMethodWithNode: aCompiledMethodWithNode inCategory: category withStamp: changeStamp notifying: requestor
    | priorMethodOrNil newText |
    priorMethodOrNil := self compiledMethodAt: aCompiledMethodWithNode selector ifAbsent: [].
    newText := aText.
    aCompiledMethodWithNode method putSource: newText
        fromParseNode: aCompiledMethodWithNode node
        class: self category: category withStamp: changeStamp
        inFile: 2 priorMethod: priorMethodOrNil.

dependent on SyntaxError that is part of Tools. So it should be override of Tools or we need better refactored solution.

Notes
(0007030)
Krivanek   
09-09-06 18:09   
the same for ClassDescription