Mantis - Squeak
Viewing Issue Advanced Details
ID: Category: Severity: Reproducibility: Date Submitted: Last Update:
4814 Kernel minor always 09-09-06 16:32 09-30-13 23:14
Reporter: Krivanek Platform:  
Assigned To: tim OS:  
Priority: normal OS Version:  
Status: closed Product Version: 3.10  
Product Build: Resolution: fixed  
Projection: none      
ETA: none Fixed in Version: 4.4  
Summary: 0004814: [KernelImageOverride] MultiCompositionScanner setFont
Description: MultiCompositionScanner >> setFont

original:

setFont
    super setFont.
    breakAtSpace _ false.
    wantsColumnBreaks == true ifTrue: [
        stopConditions _ stopConditions copy.
        stopConditions at: TextComposer characterForColumnBreak asciiValue + 1 put: #columnBreak.
    ].

override:

setFont
    super setFont.
    breakAtSpace := false.
    wantsColumnBreaks == true ifTrue: [
        stopConditions := stopConditions copy.
        stopConditions at: 12 + 1 put: #columnBreak.
    ].

dependent classes are not present in KI so fixed numbers were used
Steps To Reproduce:
Additional Information:
Relationships
Attached Files:

Notes
(0007029)
Krivanek   
09-09-06 18:06   
the same in CompositionScanner
(0007040)
kwl   
09-10-06 10:54   
I suggest to move #characterForColumnBreak to class Character, where everybody can use it (and it is shared if some non-kernel package needs that value).

So instead TextComposer characterForColumnBreak
we'd have Character characterForColumnBreak.
(0014458)
tim   
09-30-13 23:13   
It's ridiculous to have TextComposer maintaining a Character constant.
Added it to Character, change TextComposer to delegate it, changed senders to use Character version.
Collections-tpr.537 Author: tpr Time: 30 September 2013
Name: Graphics-tpr.241 Author: tpr Time: 30 September 2013
Name: MorphicExtras-tpr.120 Author: tpr Time: 30 September 2013
(0014459)
tim   
09-30-13 23:14   
TextComposer class>characterForColumnBreak should be deprecated sometime