Mantis - Squeak
Viewing Issue Advanced Details
519 Morphic crash always 11-14-04 02:54 01-12-05 17:21
wiz  
bert  
normal  
closed  
fixed  
none    
none 3.8  
0000519: [BUG] Navigator buttons invoke crash
In fresh squeak (3.9a-6404). Open navigator flap.
Press "Share." When asked for name press cancel.
emergency screen is invoked.
A picture of the emergency output is attached.
Clipping canvas DNU asBalloonCanvas seems to be the cause of the problem.
 bug.gif [^] (42,724 bytes) 11-14-04 02:54
 SafeToServe-wiz.3.cs.gz [^] (569 bytes) 01-09-05 22:41

Notes
(0000915)
laza   
12-12-04 14:55   
Same thing on 3.8b 6527
(0001016)
bert   
01-07-05 19:40   
You need to close the Flash Squeak Icon before enabling sharing.
(0001042)
wiz   
01-09-05 06:20   
Hi Bert.


When I envoked the bug I didn't want to share anything. When I tried to get out of sharing by canceling the fill in the blank I expected a normal termination and exit from the sharing. There should be a check for a balk before anything exciting is attempted. That much at least should be fixable.

And if a flash icon interferes with actual sharing a check should be provided before the walkback and emergency screen gets invoked.

It does not seem acceptable to me to leave this unfixed and call the issue resolved.
(0001045)
wiz   
01-09-05 22:44   
There that should do the trick.
Gzipped cs uploaded. I check this in 3.9a and it does what I intended warns and does nothing. As more problems turn up add them to the test.

'From Squeak3.9alpha of ''2 November 2004'' [latest update: 0006532] on 9 January 2005 at 3:37:57 pm'!
"Change Set: SafeToServe-wiz
Date: 9 January 2005
Author: (wiz) Jerome Peace

Fix for Mantis bug 0000519. Navigator share button leads to emergency crash when squeak logo present."!


!NebraskaServerMorph class methodsFor: 'as yet unclassified' stamp: 'wiz 1/9/2005 15:12'!
serveWorld: aWorld
    "Check to make sure things won't crash. See Mantis 0000519"
    aWorld isSafeToServe ifTrue:[
    ^self serveWorld: aWorld onPort: NebraskaServer defaultPort]
    ! !


!PasteUpMorph methodsFor: 'Nebraska' stamp: 'wiz 1/9/2005 15:37'!
isSafeToServe
"True if all conditions are met to share safely.
(attends to mantis bug 0000519).
Right now we reject worlds with FlashMorphs for subMorphs."

 (self findA: FlashMorph) ifNil: [^true] .
Warning signal: 'Can not share world if Squeaklogo is present. Collapse logo and try again' .
^false .! !
(0001067)
bert   
01-12-05 17:21   
thanks!
(0001068)
bert   
01-12-05 17:21   
update 6550SafeToServe-wiz.cs