Mantis - Croquet
Viewing Issue Advanced Details
5568 Hedgehog major always 12-04-06 03:54 12-04-06 04:33
howardstearns  
 
normal  
new  
open  
none    
none  
0005568: CroquetParticipantWithMenu>>mouseEnter: doesn't test for null openAL
It is:
mouseEnter: evt
    super mouseEnter: evt.
    harness ifNotNil: [
        harness openAL isCurrent ifFalse: [
            harness makeOpenALCurrent.
        ].
    ].
But harness openAL can be nil if the machine doesn't have the right hardware/software setup, in which case we get an error. In general, we test for openAL being nil, and we should here, too:
Fix is:
CroquetParticipantWithMenu>>mouseEnter: evt
    super mouseEnter: evt.
    harness ifNotNil: [
        harness openAL ifNotNilDo: [:oal | oal isCurrent ifFalse: [harness makeOpenALCurrent].
        ].
    ].

Notes
(0008532)
howardstearns   
12-04-06 04:33   
Well, probably not "major".

We ought to decide someday what that means. For example, in some places "major" means you end up in the debugger, which is the case here. But there's a lot of other cases where that happens, which we haven't designated "major."