Mantis - Squeak
Viewing Issue Advanced Details
5619 Morphic crash always 12-08-06 02:29 09-08-08 17:36
wiz  
wiz  
normal  
closed 3.9  
fixed  
none    
none 3.10  
0005619: {Fix] [Test] In 7067 (and before) sending #heading to a TransformationMorph w/o a rendee recurses infinitly
In a workspace evaluate
"TransformationMorph new openCenteredInWorld heading"

use Cmd-dot to stop the recursion.

Same bug is present for #heading:,
#forwardDirection, and #forwardDirection: .
I found this while browsing code.

Coming across this bug in the wild is fairly rare but it can happen.

The rendered morph can be deleted leaving a naked TMorph to field rotation requests. I ran into it while trying to fix rotation for polygons.

(With out a renderer rotating correctly requires requesting your submorphs rotate as well.)

A fix is in the works and will be uploaded after some reassuring tests.

Yours in service, --Jerome Peace
related to 0006429closed  [Fix ] Test suite could not run tests because they didn't follow naming convention. 
 RenderBugz.1.cs [^] (3,236 bytes) 12-08-06 03:49
 ForwardDirFix-wiz.5.cs [^] (2,150 bytes) 12-08-06 03:50
 setHeadingFix-wiz.1.cs [^] (487 bytes) 04-18-07 20:25

Notes
(0008628)
wiz   
12-08-06 03:55   
Uploaded the tests and the fix.

I was able to get the tests to catch the recursion and properly cleanup after itself.

The fix addresses the four accessors and does a minor refactoring for #renderedMorph. No reason to test in Morph when an overide in the rendering classes is more elegant.

Yours in service, Jerome Peace
(0010567)
edgardec   
04-17-07 12:13   
This now is part of 7080wizFixesOfMorph.cs and was in updates for 3.10
Thanks Jerome !
(0010577)
wiz   
04-18-07 20:29   
missed one of the patches (the one for #heading:) which is now uploaded here.
It has also been uploaded to the related issue (the test fixes).
It is here for completeness.
(0011459)
matthewf   
11-24-07 16:56   
Reminder sent to: edgardec

Has this issue been fixed? I cannot tell from the comments
(0011462)
edgardec   
11-24-07 19:49   
TransformationMorph new openCenteredInWorld heading don't gives me any funny, maybe Jerome have some to say, but seems solved.
This is for Squeak3.10.1beta.7155.image
(0011470)
wiz   
11-24-07 21:29   
I checked the fix is in sq7155. The tests all pass and nothing recurses infinitly which was the problem.
(0011471)
wiz   
11-24-07 21:30   
Fixed in sq 7155 (or maybe a little before)
(0012592)
KenCausey   
09-08-08 17:36   
Harvested in update 7080 except TransformationMorph>>heading: harvested in update 7116 both included in 3.10 release.