Mantis - Squeak
Viewing Issue Advanced Details
6174 Browser minor always 02-19-07 23:36 03-19-08 18:53
black  
 
normal  
new 3.9  
open  
none    
none  
0006174: Refactoring Browser gives MNU on user error
If the user mistakenly asks the Refactoring Browser to "inline temporary variable" while the selection is an assignment to an _instance variable_, the refactoring's pre-condition is not met and the user should be given a polite message to that effect.

The user currently gets a MNU walkback!

The attached fixes this problem.
I have included a test, which errors on the current code base, and passes after the fix is installed.
 RBInlineTempFix.2.cs [^] (1,437 bytes) 02-19-07 23:36

Notes
(0011934)
GazzaGuru   
03-19-08 18:23   
We at Pinesoft have just done a temporary fix for this:

BrowserRequestor>>getArgumentPermutation
    "Answer the argument permutation map.
    No support for changing argument count."
    
    ^(1 to: (self getBrowser selectedMessageName ifNil: [^nil]) numArgs) asArray
(0011936)
GazzaGuru   
03-19-08 18:53   
Sorry, wrong bug #...