Mantis - Squeak
Viewing Issue Advanced Details
6548 Tools minor always 06-28-07 10:47 03-30-13 21:39
cdrick  
FrankShearar  
normal  
@70@ 3.9  
open  
none    
none  
0006548: [BUG][FIX]StringHolder>>browseMethodFull - doesn't use the default browser
In an object explorer, right click then browse on a node opens the default browser even if your default browser is different (Omnibrowser, PackagePaneBrowser...).

It comes from #browseMethodFull in StringHolder (extension of the Tools package) which doesn't use the generic tool dispatch.

I changed:
Browser fullOnClass: myClass selector: self selectedMessageName
with:
ToolSet browse: myClass selector: self selectedMessageName.

see provided change set
 StringHolder-browseMethodFull.st [^] (392 bytes) 06-28-07 10:47

Notes
(0010840)
cdrick   
06-28-07 10:53   
sorry, bad description and I don't know how to edit... if someone can do that...

Should be:

[BUG][FIX]StringHolder>>browseMethodFull - doesn't use the default browser
(0010841)
wiz   
06-28-07 17:49   
Fixed the report name.

It would be good if you could come up with a test that fails before the fix and passes after. It will help the harvesters and insure the problem doesn't sneak back in.

Yours in curiosity and service, --Jerome Peace
(0014345)
FrankShearar   
03-30-13 21:39   
Testing by virtue of pushing it into Trunk, as Tools-fbs.459. Works on the default Browser.

Tests would be great, but we'd have to build an enormous amount of testing infrastructure before we could write such a test... for a one-line fix.