Mantis - Squeak
Viewing Issue Advanced Details
6778 Collections minor always 11-20-07 01:07 04-18-10 22:04
nicolas cellier  
andreas  
normal  
closed 3.10  
fixed  
none    
none trunk  
0006778: SkipList copy is shallow
"changing the copy changes the original"
    | original copy |
    original := SkipList new.
    original at: 3 put: '3333'.
    copy := original copy.
    copy remove: 3.
    self assert: (original includes: 3).
same as 0006777
related to 0007359closed KenCausey SkipLists code is covered by a combination of MIT and SqueakL 
 SkipList-copy-Test-M6778-nice.1.cs [^] (731 bytes) 03-26-08 21:26
 SkipList-copy-Patch-M6778-nice.1.cs [^] (1,235 bytes) 03-26-08 22:58
 SkipList-copy-Patch-M6778-nice.2.cs [^] (1,263 bytes) 03-26-08 23:29

Notes
(0011959)
nicolas cellier   
03-26-08 22:59   
"fix begin"
Installer mantis bug: 6778 fix:'SkipList-copy-Patch-M6778-nice.1.cs'.
"fix test".
Installer mantis bug: 6778 fix:'SkipList-copy-Test-M6778-nice.1.cs'.
"fix end"
(0011960)
nicolas cellier   
03-26-08 23:26   
"Ah, my first patch is bad, i forgot sortBlock..."

"fix begin"
Installer mantis bug: 6778 fix:'SkipList-copy-Patch-M6778-nice.2.cs'.
"fix test".
Installer mantis bug: 6778 fix:'SkipList-copy-Test-M6778-nice.1.cs'.
"fix end"

(0013151)
KenCausey   
07-04-09 18:15   
I have published a version of Collections without SkipLists at

http://source.squeak.org/trunk/Collections-klc.93.mcz [^]

and SkipLists as an external package at

http://www.squeaksource.com/SkipLists.html [^]
(0013152)
KenCausey   
07-04-09 18:23   
I have included the SkipList-copy-Patch-M6778-nice.2.cs fix and SkipList-copy-Test-M6778-nice.1.cs test in http://www.squeaksource.com/skiplists/SkipLists-klc.2.mcz [^]
(0013329)
KenCausey   
10-04-09 17:23   
This was fixed basically by removing the code to which the issue replied from the base image. SkipLists reports should now go in the Squeak Packages project. And note above that this issue was fixed in an external release of the package.