Mantis - Squeak
Viewing Issue Advanced Details
6998 Collections minor always 04-02-08 21:43 04-18-10 22:05
nicolas cellier  
andreas  
normal  
closed 3.10  
fixed  
none    
none trunk  
0006998: WideString>>at:put: does not return the put-object
Every other Collection does return the put-object.
a WideString would returns self...
It should not!

Thanks to Randal Schwartz for raising the question on #squeak channel.
related to 0001913closed  Make all implementors of #nextPut: to return the argument (instead of self) 
 WideString-atput-Test-M6998-nice.1.cs [^] (648 bytes) 04-02-08 21:57
 WideString-atput-Patch-M6998-nice.1.cs [^] (585 bytes) 04-02-08 21:57

Notes
(0011966)
nicolas cellier   
04-02-08 22:31   
Should also be the case of TwoLevelDictionary...
However, this one is more private, only used in:

TextDiffBuilder>>buildPatchSequence
    "@@ TODO: Das funktioniert noch nicht für n-m matches"
(0012014)
kwl   
04-11-08 21:21   
Nicolas,
I'm happy you found this. when I found issue 0001913 I checked what the VM returns (what will be returned if primitive does not fail). with #at:put: it is also possible to run into the same situation, since in many cases #at:put: can be handled by the VM alone.
Good find!
(0012861)
Keith_Hodges   
12-17-08 04:43   
"fix begin"
Installer mantis bug: 6998 fix: 'WideString-atput-Patch-M6998-nice.1.cs'.
"fix test"
Installer mantis bug: 6998 fix: 'WideString-atput-Test-M6998-nice.1.cs'.
"fix end"
(0013263)
nicolas cellier   
08-24-09 20:02   
Fixed in http://source.squeak.org/trunk/Collections-nice.106.mcz [^]