Mantis - Squeak
Viewing Issue Advanced Details
7177 Collections minor always 09-03-08 14:06 04-18-10 22:04
Keith_Hodges  
andreas  
normal  
closed 3.10.2  
fixed  
none    
none trunk  
0007177: removeAll fails for Dictionaries
The standard implementation of #removeAll is slow, and doesnt cover any of the varieties of Dictionary. Simply replacing #removeAll with an initialize solves both of these problems
related to 0006937closed kwl removeAll: aCollection doesn't do what we expect if aCollection==self 
 Set-Dictionary-fast-removeAll-M7177.1.cs [^] (205 bytes) 09-03-08 14:07
 M7177-Collection-removeAll-nice-Patch.1.cs [^] (3,806 bytes) 01-10-09 00:04

Notes
(0012578)
Keith_Hodges   
09-03-08 14:08   
"fix begin"
Installer mantis bug: 7177 fix: 'Set-Dictionary-fast-removeAll-M7177.1.cs'.
"fix end"
(0012909)
nicolas cellier   
01-10-09 00:07   
Hello Keith, I did not check your patch before...
Maybe you can review mine in case it is more complete...
I have no #removeAll in my image. Where does it come from?

Last, I tried to address 0006937 (but defunct MappedCollection case).
(0013305)
nicolas cellier   
09-14-09 18:51   
I uploaded my version in http://source.squeak.org/trunk/Collections-nice.130.mcz [^]
I added some tests in http://source.squeak.org/trunk/CollectionsTests-nice.94.mcz [^]
Keith, if you have other sources of interest (alternative or complementary removeAll implementations and tests), please provide links.