Mantis - Squeak
Viewing Issue Advanced Details
7248 Graphics minor always 12-18-08 23:49 09-30-13 22:51
timj  
andreas  
normal  
closed 3.10.2  
fixed  
none    
none 4.4  
0007248: TextAnchor breaks Paragraph parsing process
Changes made to TextAnchor in 3.9 broke it (ScriptLoader>>#script31). In Squeak 3.2, TextAnchor>># was specifically meant to be a noop. In 3.9 and 3.10, TextAnchor implements code which interrupts processes already working in the Paragraph render tree, and causes a DNU. I propose that we back off from the change and return TextAnchor to its original functionality, which is to do nothing.
The only code in the base image which uses TextAnchor is BadgeMorph. BadgeMorph does not work with changes to TextAnchor in 3.9 and 3.10. With this fix, it works again as it did in 3.8.
 TextAnchor-emphasizeScanner.st [^] (421 bytes) 12-18-08 23:49
 M7248-TextAnchor-emphasizeScanner.st [^] (395 bytes) 12-19-08 00:06
 TextAnchorM7248Test.st [^] (567 bytes) 12-19-08 00:08

Notes
(0012871)
timj   
12-18-08 23:51   
The description field should read:

Changes made to TextAnchor in 3.9 broke it (ScriptLoader>>#script31). In Squeak 3.2, TextAnchor>>#emphasizeScanner was specifically meant to be a noop. In 3.9 and 3.10, TextAnchor>>#emphasizeScanner implements code which interrupts processes already working in the Paragraph render tree, and causes a DNU. I propose that we back off from the change and return TextAnchor>>#emphasizeScanner to its original functionality, which is to do nothing.
(0012872)
timj   
12-19-08 00:07   
Please ignore the first attachment. It uses #shouldNotImplement which is totally wrong!
(0014455)
tim   
09-30-13 22:51   
This seems to be resolved; TextAnchor code passes its tests and all looks ok.
No idea when it was actually sorted out.