Mantis - Croquet
Viewing Issue Advanced Details
904 Any major always 02-26-05 00:39 05-04-05 03:52
elenzil  
 
normal  
new  
open  
none    
none  
0000904: VRMLNodeParser - no textures on 'large' files, with fix.

I'm using the VRML2 importer in croquet,
it's pretty good; thanks Dave Faught et al!

I noticed that some files imported their texture correctly
and some didn't.

The problem turned out to be in
VRMLNodeParser >> parseFileNamed:

there was a test (why?) on file size which,
if the file is larger than 500,000,
called parse: without passing in the file path.

attached is a corrective changeset.

- i don't understand why this test is being made however,
so someone more involved in the VRML import may want to think about my change.
 VRMLNodeParser class.oxe.1.cs [^] (714 bytes) 02-26-05 00:39

Notes
(0001459)
dfaught   
05-04-05 03:52   
Orion's fix was included into the most recent VRMLCroquetBuilder package on SqueakMap a couple of weeks ago, so this could probably be closed.