Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006405 [Squeak] Collections block always 04-10-07 07:46 09-08-08 15:05
Reporter Damien Cassou View Status public  
Assigned To KenCausey
Priority normal Resolution fixed  
Status closed   Product Version 3.10
Summary 0006405: String>>keywords implementation is based on wrong behavior of PositionableStream>>isEmpty
Description String>>keywords tests for an empty stream when it should test for a stream at begining. This didn't cause any problem before because PositionableStream>>isEmpty was equivalent to this behavior. But this is not what #isEmpty is meant for (see http://bugs.squeak.org/view.php?id=2273). [^]

In the attached fix, I propose to change the implementation of String>>keywords from:

... kwd isEmpty...

to

... kwd position = 0 ...

Tests are present in the attached file too.
Additional Information
Attached Files  String_keywords.1.cs [^] (1,239 bytes) 04-10-07 07:46

- Relationships
duplicate of 0006409closed wiz in 7081 :7076fixPositionableStream-isEmpty.1.cs was wrong fix. Prettyprint broken by it. 

- Notes
(0010512 - 81 - 87 - 87 - 87 - 87 - 87)
edgardec
04-10-07 10:11

This now is 7083fixStringkeywords.cs and was in updates for 3.10
Thanks Damien !
 
(0010513 - 22 - 22 - 22 - 22 - 22 - 22)
Damien Cassou
04-10-07 10:13

The bug can be closed.
 
(0010515 - 39 - 39 - 39 - 39 - 39 - 39)
Damien Cassou
04-10-07 10:16

The fix is included into update stream.
 
(0012587 - 24 - 24 - 24 - 24 - 24 - 24)
KenCausey
09-08-08 15:05

harvested in update 7083
 

- Issue History
Date Modified Username Field Change
04-10-07 07:46 Damien Cassou New Issue
04-10-07 07:46 Damien Cassou File Added: String_keywords.1.cs
04-10-07 10:11 edgardec Note Added: 0010512
04-10-07 10:13 Damien Cassou Note Added: 0010513
04-10-07 10:14 Damien Cassou Issue Monitored: Damien Cassou
04-10-07 10:16 Damien Cassou Status new => closed
04-10-07 10:16 Damien Cassou Note Added: 0010515
04-10-07 10:16 Damien Cassou Resolution open => fixed
04-12-07 23:52 wiz Relationship added has duplicate 0006409
09-08-08 15:05 KenCausey Relationship replaced duplicate of 0006409
09-08-08 15:05 KenCausey Duplicate ID 0 => 6409
09-08-08 15:05 KenCausey Status closed => resolved
09-08-08 15:05 KenCausey Fixed in Version  => 3.10
09-08-08 15:05 KenCausey Assigned To  => KenCausey
09-08-08 15:05 KenCausey Note Added: 0012587
09-08-08 15:05 KenCausey Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
65 total queries executed.
43 unique queries executed.
Powered by Mantis Bugtracker