Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001523 [Squeak] Network minor always 07-22-05 18:46 04-18-07 11:35
Reporter mzimmerm View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Version
Summary 0001523: [FIX] FTPBinaryModeFix-nk
Description ned@squeakland.org:

"from preamble:

"Change Set: FTPBinaryModeFix-nk
Date: 26 January 2005
Author: Ned Konz

Between opening files as MultiByteFileStreams and not setting the FTP
servers into binary mode, we weren't getting reliable transfers of
binary data.

This change set ensures that the same bytes end up on both sides of the
wire.
"!"
Additional Information
Attached Files  FTPBinaryModeFix-nk.cs.gz [^] (1,168 bytes) 07-22-05 18:46

- Relationships
child of 0001526new  [ENH] FTPDragNDrop-nk 

- Notes
(0001872 - 280 - 338 - 338 - 338 - 338 - 338)
mzimmerm
07-22-05 18:56

frank.shearar@rnid.org.uk:

"The changes are simple.

One thing that would be really nice is a suite of tests. This would
either require a mockup of the network or a working FTP server in the
image. (A remote FTP server as a fixture in a test suite is a Bad Idea.)

frank"
 
(0001873 - 226 - 283 - 327 - 327 - 327 - 327)
mzimmerm
07-22-05 18:59

Michael Rueger <michael@squeakland.org>:

"But what if you want ascii transfer? This change set forces binary mode
in all kinds of places (e.g. getFileNamed:) that are not necessarily
meant to be binary IMO."

Michael"
 
(0001874 - 352 - 422 - 462 - 462 - 462 - 462)
mzimmerm
07-22-05 19:00

Ned Konz <ned@squeakland.org>:

"Is character translation properly the job of a file transfer protocol?

My feeling is that it isn't; that it is a service that should be provided by a
higher layer. If a particular *use* of a transferred file requires
translating line endings, then that use is welcome to provide that service.

--
Ned Konz"
 
(0001875 - 135 - 135 - 135 - 135 - 135 - 135)
mzimmerm
07-22-05 19:01

When moving this item from BFAV to mantis I verified the changeset installs in 3.8-6665 final, but did not perform any further testing.
 
(0010576 - 104 - 122 - 122 - 122 - 122 - 122)
edgardec
04-18-07 11:35

Reminder sent to: gokr


I wish harvest as many code here as possible for 3.10
Goran what you have to say ?
It's this good ?
 

- Issue History
Date Modified Username Field Change
07-22-05 18:46 mzimmerm New Issue
07-22-05 18:46 mzimmerm File Added: FTPBinaryModeFix-nk.cs.gz
07-22-05 18:56 mzimmerm Note Added: 0001872
07-22-05 18:59 mzimmerm Note Added: 0001873
07-22-05 19:00 mzimmerm Note Added: 0001874
07-22-05 19:01 mzimmerm Note Added: 0001875
07-22-05 20:33 KenCausey Relationship added parent of 0001526
07-22-05 20:36 KenCausey Relationship deleted parent of 0001526
07-22-05 20:37 KenCausey Relationship added child of 0001526
04-18-07 11:35 edgardec Issue Monitored: gokr
04-18-07 11:35 edgardec Note Added: 0010576


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
63 total queries executed.
39 unique queries executed.
Powered by Mantis Bugtracker