Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001625 [Squeak] Morphic minor always 08-07-05 05:33 02-15-06 19:02
Reporter wiz View Status public  
Assigned To
Priority normal Resolution fixed  
Status closed   Product Version 3.8
Summary 0001625: [Fix] Thumbnails scale size now fixed for forms as well as morphs.
Description In 3.7 thumbnails would showup bigger than their bounds when aspect ratios were not just so. Scott fixed the aspect ratios for morphs but missed the branch that dealt with the simpler case of forms.

When using Lex Spoons wonderful pop up images this became obvious.
So I factored out the scale calculations and fixed it.

Additional Information
Uploaded is the fix for thumbnails and also the popup images class so the fix can be verified by others.

To see the problem load the pop up images stuff first.
Drop a morph onto a sample instance and grow the popup thumbnail so it is wide but not tall. The thumbnail will exceed the bounds.

Then try it with the fixes to verify they work.

Attached Files  TnailFormFix-wiz.2.cs [^] (3,594 bytes) 08-07-05 05:33
 CDScreenShotMorph.wiz.2.cs [^] (1,675 bytes) 08-07-05 05:36

- Relationships

- Notes
(0002184 - 172 - 196 - 196 - 196 - 196 - 196)
wiz
08-07-05 05:42

CDScreenShotMorph.wiz.2.cs is lex's stuff extracted from ChuckDemo.zip

TnailFormFix-wiz.2.cs are fixes to TNM based on code in 3.8-6665.

This fix is dedicated to Lex.
 
(0003871 - 697 - 799 - 799 - 799 - 799 - 799)
MarcusDenker
02-15-06 19:02

in 3.9

Name: MorphicExtras-jmv.9
Author: jmv
Time: 12 January 2006, 1:33:41 pm
UUID: 2720167c-765e-9541-8f14-dd3789d8fca8
Ancestors: MorphicExtras-CdG.7

This version includes stuff from one or more of:
Mantis-1092-MorphDropFix, fix by Edgar De Cleene (edc) and Scott Wallace (sw)
Mantis-0503-TargetSighting, fix by Jerome Peace (wiz)
Mantis-1015-SnapView, fix by Jerome Peace (wiz)
Mantis-1771-ClickExerciser, fix by Jerome Peace (wiz)
Mantis-1625-Thumbnails, fix by Jerome Peace (wiz)
Mantis-1484-TrashHalo, fix by Jerome Peace (wiz)
Mantis-1454-ArrowPrototypeFix, fix by Jerome Peace (wiz)
Mantis-1347-ListDoubleClick, fix by Jerome Peace (wiz)
Reviewed by Juan Vuletich (jmv)
 

- Issue History
Date Modified Username Field Change
08-07-05 05:33 wiz New Issue
08-07-05 05:33 wiz File Added: TnailFormFix-wiz.2.cs
08-07-05 05:36 wiz File Added: CDScreenShotMorph.wiz.2.cs
08-07-05 05:42 wiz Note Added: 0002184
02-15-06 19:02 MarcusDenker Status new => closed
02-15-06 19:02 MarcusDenker Note Added: 0003871
02-15-06 19:02 MarcusDenker Resolution open => fixed
02-15-06 19:02 MarcusDenker Fixed in Version  => 3.9


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
43 total queries executed.
32 unique queries executed.
Powered by Mantis Bugtracker