Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001739 [Squeak] Network minor always 08-23-05 21:50 08-23-05 22:01
Reporter benschroeder View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Version
Summary 0001739: [BUG][FIX] HTTPSocket>>httpGet: and redirecting without host names
Description HTTPSocket>>httpGet: has a bug when trying to handle HTTP redirects that
did not include a host name, like "/some/file". The attached changeset
fixes the bug.

>From the preamble:

"Change Set: FixHTTPRedirectsWithoutHostName-bvs
Date: 11 January 2005
Author: Benjamin Schroeder

HTTPSocket has a method to get a web page, #httpGet:. This method
handles redirects.

However, #httpGet: was failing on redirects that gave the new location
as a full path with no host name, such as '/some/file'. (Seaside - at
least while running on Komanche but possibly elsewhere - issues
redirects like this.)

This changeset fixes the behavior."
Additional Information
Attached Files  FixHTTPRedirectsWithoutHostName-bvs.1.cs.gz [^] (909 bytes) 08-23-05 21:50

- Relationships

- Notes
(0002500 - 523 - 611 - 653 - 653 - 653 - 653)
KenCausey
08-23-05 21:55

Avi Bryant <avi.bryant@gmail.com>:

"> However, #httpGet: was failing on redirects that gave the new location
> as a full path with no host name, such as '/some/file'. (Seaside - at
> least while running on Komanche but possibly elsewhere - issues
> redirects like this.)

Just fyi - if you fill in a hostname on the Seaside config page, it
will use absolute URLs for its redirects and elsewhere. Technically,
I believe, relative redirects are not legal in HTTP, although most
browsers do handle them just fine."
 
(0002501 - 529 - 747 - 1120 - 1120 - 1120 - 1120)
KenCausey
08-23-05 21:57

willem van den ende <squeak@willemvandenende.com>:

"> Technically,
> I believe, relative redirects are not legal in HTTP,

That is correct, the http 1.1. spec (I was just reading it yesterday) says
about the location field (used for amongst other things redirects):

http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30 [^]

"The field value consists of a single absolute URI.

       Location = "Location" ":" absoluteURI

An example is:

       Location: http://www.w3.org/pub/WWW/People.html"" [^]
 
(0002502 - 120 - 120 - 120 - 120 - 120 - 120)
KenCausey
08-23-05 22:01

I loaded this into 3.8-6665-basic without errors and ran the included test which passed. I did not test this otherwise.
 

- Issue History
Date Modified Username Field Change
08-23-05 21:50 KenCausey New Issue
08-23-05 21:50 KenCausey File Added: FixHTTPRedirectsWithoutHostName-bvs.1.cs.gz
08-23-05 21:52 KenCausey Reporter KenCausey => benschroeder
08-23-05 21:55 KenCausey Note Added: 0002500
08-23-05 21:57 KenCausey Note Added: 0002501
08-23-05 22:01 KenCausey Note Added: 0002502
12-10-05 12:35 pmm Issue Monitored: pmm


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
46 total queries executed.
33 unique queries executed.
Powered by Mantis Bugtracker