0001835: [Bug] Duplicating an UpdatingMenuMorph loses its target.

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001835

[Squeak] Morphic

minor

always

10-03-05 21:15

02-11-08 23:02

Reporter

wiz

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Product Version

3.9

Summary

0001835: [Bug] Duplicating an UpdatingMenuMorph loses its target.

Description

For this one.
Get a curve or polygon.
Using the halos get the red menu.
Make it stay up.
Get a halo around the menu and the around the show handles item.
Using the dup handle get a copy of the show handles button.

Press the show handles on the stay up menu. The handles appear on the polygon and the menu item now says hide handles. The duplicated menu item has not changed.

Now press the duplicated menu item. The item changes wording from show to hide (and back if you keep pressing) but there is no change of the polygon handles.

Additional Information

This is a long time bug and is present in Squeak 3.6 and presumable earlier. I have not checked.

The problem is that when duplicated the UpdatingMenuMorph makes a copy of its target which is not what is wanted. This target is not open in the world. So while the button causes changes in it nothing visible happens.

The cure is for the dup handle to know to preserve the target.
This must be doable because non-updating items preserve their targets and work fine as duplicated buttons.

This report is related to Mantis 0001832.

Attached Files

1241MenuCopyFix2-tk.1.cs [^] (34,576 bytes) 02-11-08 23:01

Relationships

SYSTEM WARNING: Creating default object from empty value

related to	0001832	new		In 6693 A reproducible way to get into a strange state using menus.
related to	0006897	closed	KenCausey	Retargeting an UpdatingMenuItem needs to consider the wording provider.
child of	0006530	new		A mother for button, slider and menuItem targeting and argumenting related reports.

Notes
(0011210 - 192 - 202 - 202 - 202 - 202 - 202) ScottWallace 09-27-07 00:16	Anyone wishing to fix this in Squeak 3.x will likely benefit from taking a look at olpc etoys update "1241MenuCopyFix2-tk", which addresses a broad range of copying issues, including this one.

(0011764 - 107 - 113 - 113 - 113 - 113 - 113) wiz 02-11-08 23:02	As per Scott's suggestion I filed out the cs and uploaded it here. Haven't had a chance to look at it yet.

Issue History
Date Modified	Username	Field	Change
10-03-05 21:15	wiz	New Issue
06-06-07 02:36	wiz	Relationship added	child of 0006530
09-26-07 03:07	matthewf	Relationship added	related to 0001832
09-27-07 00:16	ScottWallace	Note Added: 0011210
02-11-08 23:01	wiz	File Added: 1241MenuCopyFix2-tk.1.cs
02-11-08 23:02	wiz	Note Added: 0011764
02-11-08 23:33	wiz	Relationship added	related to 0006897

Mantis 1.0.8[^]

67 total queries executed.
51 unique queries executed.