Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0002168 [Squeak] Graphics minor always 11-10-05 10:32 01-31-06 16:32
Reporter Herbert Koenig View Status public  
Assigned To andreas
Priority normal Resolution fixed  
Status closed   Product Version 3.9
Summary 0002168: Point>>theta uses single precision constants in the special case and sends in the general case tan := y / x . dir := tan ar
Description Point>>theta uses single precision constants in the special cases of zero x-coordinate while it uses sends instead of constants in the more general case of negative x.

I've attached a fix using full precision constants and constants instead of sends. There also is test for precision.

I've checked the speed improvement manually and it is considerable.
If someone can tell me how to write a proper test for the speed improvement, please do so!
Additional Information Verified in 3.7, 3.8 and 3.9

Used the fix in 3.7 but ran the tests only in 3.8

From a mathematical point of view I think this bug is severe but I'm just an engineer and for my field of application I consider it just ugly but good enough.

So feel free to change the severity.
Attached Files  theta_and_test.zip [^] (1,065 bytes) 11-10-05 10:32

- Relationships

- Notes
(0003218 - 233 - 233 - 233 - 233 - 233 - 233)
andreas
12-07-05 01:09

Thanks for the fix; it's been integrated. BTW, for the next bug report, please use multiple attachments instead of a zip file. It's a *lot* easier for people to look and comment if they don't have to go through the extra indirection.
 
(0003247 - 104 - 104 - 104 - 104 - 104 - 104)
ducasse
12-09-05 20:30

Andreas how do we proceed then. You push a mcz into the inbox and send an email to the v3.9 mailing-list
 
(0003248 - 157 - 157 - 157 - 157 - 157 - 157)
andreas
12-09-05 20:39

All in due time. There is no reason why this particular bug would require an immediate new release of the graphics package. BTW, why did you reopen this bug?
 
(0003260 - 276 - 294 - 294 - 294 - 294 - 294)
Herbert Koenig
12-10-05 09:53

Thanks for including it and I will remember using single unzipped files.
I'm still learning so: Would one single mcz be ok?
As for Andreas comment I see it his way, as long as people only use screen coordinates (even architecture) it will not make any difference.
-Herbert
 
(0003659 - 17 - 17 - 17 - 17 - 17 - 17)
MarcusDenker
01-31-06 16:32

is in 3.9a#latest
 

- Issue History
Date Modified Username Field Change
11-10-05 10:32 Herbert Koenig New Issue
11-10-05 10:32 Herbert Koenig Status new => assigned
11-10-05 10:32 Herbert Koenig Assigned To  => andreas
11-10-05 10:32 Herbert Koenig File Added: theta_and_test.zip
11-11-05 16:25 Herbert Koenig Issue Monitored: Herbert Koenig
12-07-05 01:09 andreas Status assigned => resolved
12-07-05 01:09 andreas Resolution open => fixed
12-07-05 01:09 andreas Note Added: 0003218
12-09-05 20:30 ducasse Status resolved => feedback
12-09-05 20:30 ducasse Resolution fixed => reopened
12-09-05 20:30 ducasse Note Added: 0003247
12-09-05 20:39 andreas Note Added: 0003248
12-10-05 09:53 Herbert Koenig Note Added: 0003260
12-30-05 09:23 andreas Status feedback => resolved
12-30-05 09:23 andreas Resolution reopened => fixed
01-31-06 09:23 Herbert Koenig Issue End Monitor: Herbert Koenig
01-31-06 16:32 MarcusDenker Status resolved => closed
01-31-06 16:32 MarcusDenker Note Added: 0003659
01-31-06 16:32 MarcusDenker Fixed in Version  => 3.9


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
66 total queries executed.
41 unique queries executed.
Powered by Mantis Bugtracker