0002259: [Fix] Better fix for Mantis #360 rotated morph rendering error.

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002259

[Squeak] Morphic

major

always

11-22-05 01:47

05-11-07 20:58

Reporter

wiz

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Product Version

3.9

Summary

0002259: [Fix] Better fix for Mantis #360 rotated morph rendering error.

Description

Get a ruler morph. Adjust it to 101 by 100.
Rotate it 90 degrees.

Desired result a rectangle with clear borders.

Results are a some what tilted rectange with some of the border missing.

Before the 6461 change set the bottom or right border would be missing though the rectangle was not tilted.

Additional Information

The almost definitive fix to Mantis 0000360.

Problem: when morphs are flexed the right bottom borders tend to get lost if extents are not even.

The cause: TformMorphs translate the bounds of the morph s.t. the origin is negative and the corner is positive. When the bounds rectangle is truncated everything shrinks towards the center. This was not quite compensated for by expanding the boundry by 1 aftertruncating. The truncation error could be as big as almost 2 pixels. The expansion would take care of one of them but add the other at the wrong edge.

The fix was to also expand by 0.99 before the truncation takes place. This prevents the shrinkage. The expansion is also need to compensate for warpbits truncation posibilities.

I also had to revert Andreas's warpfix which was better than the original problem but drew problem rectanges as tilted when rotated 90 degrees .

Attached Files

TformMorphFenceFix-wiz.2.cs [^] (3,003 bytes) 11-22-05 01:47

Relationships

duplicate of	0000360	closed	andreas	rotated morph rendering error
child of	0006511	new		Mother of all Morphic Graphical off-by-one/fencepost -error reports.

Notes
(0003190 - 235 - 247 - 247 - 247 - 247 - 247) wiz 12-01-05 02:38	I just want to point out that this is a continuation of 360 not its duplicate. 360 was closed and AFAIK once thats done all you can do is open a new one inorder to offer a refix. Squeak is incrementally maintained. Refixes happen.

(0010705 - 33 - 33 - 33 - 33 - 33 - 33) edgardec 05-11-07 20:58	Reminder sent to: wiz Jerome this is ready to include ?

Issue History
Date Modified	Username	Field	Change
11-22-05 01:47	wiz	New Issue
11-22-05 01:47	wiz	File Added: TformMorphFenceFix-wiz.2.cs
11-30-05 23:43	KenCausey	Relationship added	duplicate of 0000360
12-01-05 02:38	wiz	Note Added: 0003190
05-11-07 20:58	edgardec	Note Added: 0010705
05-25-07 02:52	wiz	Relationship added	related to 0006511
05-25-07 02:57	wiz	Relationship replaced	child of 0006511

Mantis 1.0.8[^]

51 total queries executed.
35 unique queries executed.