Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0002309 [Squeak] Morphic major always 12-09-05 01:14 01-18-06 19:17
Reporter KenCausey View Status public  
Assigned To
Priority normal Resolution fixed  
Status closed   Product Version 3.9
Summary 0002309: Slip in TheWorldMenu>>#openMenu
Description When ToolBuilder was incorporated (0001915) many methods were changed. An error was made in the changes to TheWorldMenu>>#openMenu. It looks like the definition of the menu entry for 'file...' was kind of merged with that of 'file list'.

I'm including a proposed fix.
Additional Information 8 December 2005 6:04:36 pm

VM: unix - a SmalltalkImage
Image: Squeak3.9alpha [latest update: 0006705]

SecurityManager state:
Restricted: false
FileAccess: true
SocketAccess: true
Working Dir /home/ken/projects/squeak/task1
Trusted Dir /home/ken/projects/squeak/task1/secure
Untrusted Dir /home/ken/projects/squeak/task1/My Squeak

TheWorldMenu(Object)>>doesNotUnderstand: #openFileDirectly
    Receiver: a TheWorldMenu
    Arguments and temporary variables:
        aMessage: openFileDirectly
    Receiver's instance variables:
        myProject: a Project(Unnamed1)
        myWorld: a PasteUpMorph(1622) [world]
        myHand: a HandMorph(3216)

TheWorldMenu>>doMenuItem:with:
    Receiver: a TheWorldMenu
    Arguments and temporary variables:
        aCollection: an Array(a TheWorldMenu #openFileDirectly)
        event: [943@694 mouseUp 95614]
        realTarget: a TheWorldMenu
        selector: #openFileDirectly
        nArgs: 0
    Receiver's instance variables:
        myProject: a Project(Unnamed1)
        myWorld: a PasteUpMorph(1622) [world]
        myHand: a HandMorph(3216)

[] in MenuItemMorph>>invokeWithEvent: {[(selArgCount := selector numArgs) = 0 ifTrue: [target perform: selector] ...]}
    Arguments and temporary variables:
        evt: [943@694 mouseUp 95614]
        selArgCount: 2
        w: a PasteUpMorph(1622) [world]

BlockContext>>ensure:
    Receiver: [] in MenuItemMorph>>invokeWithEvent: {[(selArgCount := selector numArgs) = 0 ifTrue: [t...etc...
    Arguments and temporary variables:
        aBlock: [] in CursorWithMask(Cursor)>>showWhile: {[oldcursor show]}
        returnValue: nil
        b: nil
    Receiver's instance variables:
        sender: BlockContext>>ensure:
        pc: 152
        stackp: 0
        nargs: 0
        startpc: 124
        home: MenuItemMorph>>invokeWithEvent:


--- The full stack ---
TheWorldMenu(Object)>>doesNotUnderstand: #openFileDirectly
TheWorldMenu>>doMenuItem:with:
[] in MenuItemMorph>>invokeWithEvent: {[(selArgCount := selector numArgs) = 0 ifTrue: [target perform: selector] ...]}
BlockContext>>ensure:
 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
CursorWithMask(Cursor)>>showWhile:
MenuItemMorph>>invokeWithEvent:
MenuItemMorph>>mouseUp:
MenuItemMorph>>handleMouseUp:
MouseButtonEvent>>sentTo:
MenuItemMorph(Morph)>>handleEvent:
MorphicEventDispatcher>>dispatchDefault:with:
MorphicEventDispatcher>>dispatchEvent:with:
MenuItemMorph(Morph)>>processEvent:using:
MorphicEventDispatcher>>dispatchDefault:with:
MorphicEventDispatcher>>dispatchEvent:with:
MenuMorph(Morph)>>processEvent:using:
MenuMorph(Morph)>>processEvent:
MenuMorph>>handleFocusEvent:
[] in HandMorph>>sendFocusEvent:to:clear: {[ActiveHand := self. ActiveEvent := anEvent. result := focusHolder han...]}
[] in PasteUpMorph>>becomeActiveDuring: {[aBlock value]}
BlockContext>>on:do:
PasteUpMorph>>becomeActiveDuring:
HandMorph>>sendFocusEvent:to:clear:
HandMorph>>sendEvent:focus:clear:
HandMorph>>sendMouseEvent:
HandMorph>>handleEvent:
HandMorph>>processEvents
[] in WorldState>>doOneCycleNowFor: {[:h | ActiveHand := h. h processEvents. capturingGesture := capturingGest...]}
Array(SequenceableCollection)>>do:
WorldState>>handsDo:
WorldState>>doOneCycleNowFor:
WorldState>>doOneCycleFor:
PasteUpMorph>>doOneCycle
[] in Project class>>spawnNewProcess {[[World doOneCycle. Processor yield. false] whileFalse. nil]}
[] in BlockContext>>newProcess {[self value. Processor terminateActive]}
Attached Files  TheWorldMenu-openMenu-file-fix.1.cs.gz [^] (621 bytes) 12-09-05 01:14

- Relationships
related to 0001915closed  Integrate PlusTool fixes 
has duplicate 0002530closed  MessageNotUnderstood: TheWorldMenu>>openFileDirectly in 6713 

- Notes
(0003252 - 67 - 67 - 67 - 67 - 67 - 67)
Eddie Cottongim
12-10-05 03:39

I had the same problem and Ken's fix worked for me. It has my vote.
 
(0003533 - 25 - 25 - 25 - 25 - 25 - 25)
MarcusDenker
01-18-06 19:17

will be fixed in 3.9a6715
 

- Issue History
Date Modified Username Field Change
12-09-05 01:14 KenCausey New Issue
12-09-05 01:14 KenCausey File Added: TheWorldMenu-openMenu-file-fix.1.cs.gz
12-09-05 01:16 KenCausey Relationship added related to 0001915
12-10-05 03:39 Eddie Cottongim Note Added: 0003252
01-17-06 23:32 KenCausey Relationship added has duplicate 0002530
01-18-06 19:17 MarcusDenker Status new => closed
01-18-06 19:17 MarcusDenker Note Added: 0003533
01-18-06 19:17 MarcusDenker Resolution open => fixed
01-18-06 19:17 MarcusDenker Fixed in Version  => 3.9


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
52 total queries executed.
38 unique queries executed.
Powered by Mantis Bugtracker