0002374: Exception class is used for signalling versus Error

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002374

[Squeak] Exceptions

minor

always

12-16-05 05:30

12-17-05 01:06

Reporter

johnmci

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Product Version

3.8

Summary

0002374: Exception class is used for signalling versus Error

Description

About 10 methods use Exception say:
scanMultiCharactersCombiningFrom: startIndex to: stopIndex in: sourceString rightX: rightX stopConditions: stops kern: kernDelta

    | encoding f nextDestX maxAscii startEncoding char charValue |
    lastIndex _ startIndex.
    lastIndex > stopIndex ifTrue: [lastIndex _ stopIndex. ^ stops at: EndOfRun].
    startEncoding _ (sourceString at: startIndex) leadingChar.
    font ifNil: [font _ (TextConstants at: #DefaultMultiStyle) fontArray at: 1].
    ((font isMemberOf: StrikeFontSet) or: [font isKindOf: TTCFontSet]) ifTrue: [
        [f _ font fontArray at: startEncoding + 1]
            on: Exception do: [:ex | f _ font fontArray at: 1].

But the comments for Exception say
Exception is an abstract class. Instances should neither be created nor trapped. In most cases, subclasses should inherit from Error or Notification rather than directly from Exception.

Should usage of Exception be changed to Error?

Additional Information

Attached Files

Relationships

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
12-16-05 05:30	johnmci	New Issue
12-16-05 05:30	johnmci	Status	new => assigned
12-16-05 05:30	johnmci	Assigned To	=> KenCausey
12-17-05 01:06	KenCausey	Assigned To	KenCausey =>
12-17-05 01:06	KenCausey	Status	assigned => new
12-17-05 01:06	KenCausey	Category	Any => Exceptions
12-18-05 17:21	pmm	Issue Monitored: pmm

Mantis 1.0.8[^]

36 total queries executed.
29 unique queries executed.