Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0002381 [Squeak] Files minor always 12-18-05 22:39 12-18-05 22:48
Reporter Eddie Cottongim View Status public  
Assigned To cdegroot
Priority normal Resolution open  
Status assigned   Product Version 3.9
Summary 0002381: [BUG] MidiFileReader can't handle certain MIDI files
Description A few midi files throw an error(below) when loaded in squeak, but read fine with other players. I'm not sure if this some unsupported MIDI feature, a bad file, or what, but we can at least tolerate it. I put a 'isNotNil' test around the problem area and the files will read now.

A problem file is included.
Additional Information UndefinedObject(Object)>>doesNotUnderstand: #'>='
MIDIFileReader>>readTrackEvents
MIDIFileReader>>readTrackContents:
MIDIFileReader>>readTrackChunk
[] in MIDIFileReader>>readMIDIFrom: {[self readTrackChunk]}
SmallInteger(Integer)>>timesRepeat:
MIDIFileReader>>readMIDIFrom:
[] in ScorePlayerMorph class>>playMidiFile: {[:midiReader | f := (FileStream oldFileNamed: fullName) binary. score := (...]}
SystemDictionary(Dictionary)>>at:ifPresent:
ScorePlayerMorph class>>playMidiFile:
SimpleServiceEntry>>performServiceFor:
[] in MenuItemMorph>>invokeWithEvent: {[(selArgCount := selector numArgs) = 0 ifTrue: [target perform: selector] ...]}
BlockContext>>ensure:
CursorWithMask(Cursor)>>showWhile:
MenuItemMorph>>invokeWithEvent:
MenuItemMorph>>mouseUp:
MenuItemMorph>>handleMouseUp:
MouseButtonEvent>>sentTo:
MenuItemMorph(Morph)>>handleEvent:
MorphicEventDispatcher>>dispatchDefault:with:

Attached Files  horde1.mid.gz [^] (11,753 bytes) 12-18-05 22:39
 midibadbytefix-efc.1.cs.gz [^] (989 bytes) 12-18-05 22:47

- Relationships

- Notes
(0003344 - 138 - 138 - 138 - 138 - 138 - 138)
Eddie Cottongim
12-18-05 22:48

Attached file avoids the problem by adding a check for nil. I'd rather know why the nil is being thrown, but don't have time to check now.
 

- Issue History
Date Modified Username Field Change
12-18-05 22:39 Eddie Cottongim New Issue
12-18-05 22:39 Eddie Cottongim Status new => assigned
12-18-05 22:39 Eddie Cottongim Assigned To  => cdegroot
12-18-05 22:39 Eddie Cottongim File Added: horde1.mid.gz
12-18-05 22:47 Eddie Cottongim File Added: midibadbytefix-efc.1.cs.gz
12-18-05 22:48 Eddie Cottongim Note Added: 0003344


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
38 total queries executed.
29 unique queries executed.
Powered by Mantis Bugtracker