0002709: Sample instances have their leftmost row of pixels clipped off.

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002709

[Squeak] Morphic

minor

always

02-12-06 03:59

03-14-06 16:14

Reporter

wiz

View Status

public

Assigned To

Priority

normal

Resolution

fixed

Status

closed

Product Version

3.9

Summary

0002709: Sample instances have their leftmost row of pixels clipped off.

Description

For this one ask for a sample instance of a polygon. Or drag one out of the supply flap or object calalog morph.

The left most border will be too narrow.

Pick it up and drop it a few times and the hidden row of pixels will reappear.

Additional Information

This seems like a symtom of a rounding or truncation error.

See also Mantis 0002453. "What is the extent of a truncated rectange."

And Mantis 0002568 "How much should warpblt inherit from bitblt."

I've added this issue because it is a specific problem.
Let's see what it takes to fix it.

Yours in service -- Jerome Peace

Attached Files

CurveBoundsTRFix-wiz.2.cs [^] (6,666 bytes) 02-23-06 22:20

Relationships

child of

0006511

new

Mother of all Morphic Graphical off-by-one/fencepost -error reports.

Notes
(0003755 - 824 - 920 - 920 - 920 - 920 - 920) wiz 02-12-06 19:49 edited on: 02-23-06 22:19	Clarification, I tried a few examples, not every object loses pixels. And the polygon was actually the CurveMorph. The culprit was aggressive premature truncation/rounding in PM>curveBounds. The fix was to remove the truncation from that method and add an appropriate adjuster ( self curveBounds expanded) in the calling method. So there are two halve to the fix. The Point and Rectangle methods to do appropriate adjustments. The changes to PolygonMorph methods computeBounds and curveBounds. Change set CurveBoundsTRFix-wiz.2.cs contains Both the point/rectangle methods and the application of them to Polygon>computeBounds and CurveBounds, With the point/rectangle methods in the image more fixes can be attempted for other classes. T/R errors abound in squeak. Yours in service, -- Jerome Peace

(0004473 - 4 - 4 - 4 - 4 - 4 - 4) MarcusDenker 03-14-06 16:14	7008

Issue History
Date Modified	Username	Field	Change
02-12-06 03:59	wiz	New Issue
02-12-06 19:49	wiz	Note Added: 0003755
02-23-06 22:19	wiz	Note Edited: 0003755
02-23-06 22:20	wiz	File Added: CurveBoundsTRFix-wiz.2.cs
03-14-06 16:14	MarcusDenker	Status	new => closed
03-14-06 16:14	MarcusDenker	Note Added: 0004473
03-14-06 16:14	MarcusDenker	Resolution	open => fixed
03-14-06 16:14	MarcusDenker	Fixed in Version	=> 3.9
05-25-07 02:51	wiz	Relationship added	related to 0006511
05-25-07 02:58	wiz	Relationship replaced	child of 0006511

Mantis 1.0.8[^]

53 total queries executed.
36 unique queries executed.