0003359: Monticello infinite loop

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003359

[Squeak] Monticello

minor

always

03-26-06 22:07

06-08-08 23:55

Reporter

nicolas cellier

View Status

public

Assigned To

avi

Priority

normal

Resolution

fixed

Status

resolved

Product Version

3.9

Summary

0003359: Monticello infinite loop

Description

I happened to have infinite loop on most actions in the MC Browser (showing the Diffing... progress bar repeatedly).

Interrupting the process, i saw it was the #addToCache method sent on most MC actions.

Stepping into, i saw that was due to the storeDiffs instVar set to true for my MCCacheRepository default.

Inspecting instVar refs and senders, the only guilty is the 'store diffs' menu item in MC Browser.
So, this is surely a wrong manipulation of me, but i feel like it's a little too easy to break things down...

Shouldn't this store diffs item be protected in case of cache ?
Couldn't it be reserved to advanced users and hidden to Monticello novices like me ? (having an advanced submenu implicitly stating don't put your nose therein)

Additional Information

execute in a 3.9a 7020 (should also work on elder images)

MCCacheRepository default doAlwaysStoreDiffs.

then try to get the changes in any version of your favourite package.

Attached Files

Relationships

Notes
(0004579 - 147 - 153 - 153 - 153 - 153 - 153) nicolas cellier 03-26-06 22:19	maybe an easy work around is to define MCCacheRepository>>#alwaysStoreDiffs as always answering false, and thus having it ignoring the menu action.

(0012285 - 125 - 125 - 265 - 265 - 265 - 265) Keith_Hodges 06-08-08 23:55	Not an Issue in LPF, just load it instead of fighting older MOnticello versions http://installer.pbwiki.com/LevelPlayingField [^]

Issue History
Date Modified	Username	Field	Change
03-26-06 22:07	nicolas cellier	New Issue
03-26-06 22:07	nicolas cellier	Status	new => assigned
03-26-06 22:07	nicolas cellier	Assigned To	=> KenCausey
03-26-06 22:19	nicolas cellier	Note Added: 0004579
03-27-06 19:52	KenCausey	Assigned To	KenCausey => avi
03-27-06 19:52	KenCausey	Category	Any => Monticello
06-08-08 23:55	Keith_Hodges	Note Added: 0012285
06-08-08 23:55	Keith_Hodges	Status	assigned => resolved
06-08-08 23:55	Keith_Hodges	Resolution	open => fixed

Mantis 1.0.8[^]

44 total queries executed.
35 unique queries executed.