0003423: methods for extracting argument names are duplicating Parser job

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003423

[Squeak] Traits

minor

N/A

04-04-06 00:30

Reporter

nicolas cellier

View Status

public

Assigned To

dvf

Priority

normal

Resolution

open

Status

assigned

Product Version

3.9

Summary

0003423: methods for extracting argument names are duplicating Parser job

Description

have a look at:
LocatedMethod>>argumentNames

implementation is open coding the parsing of selector and argument names.

It should be a parser job for several reasons:
- avoid duplicating parser code
- possible extensions to non Smalltalk syntax (should use parserClass...)

Note that despite use of perserClass, Smalltalk syntax is also implicitly presumed in
TPureBehavior>>formalParametersAt:
yet another open coded argument names parser

Additional Information

It seems that
Parser>>parseArgsAndTemps:notifying:
could do the job

The fact that TPureBehavior rely on Parser internal behavior (see senders of #endOfLastToken) is questionable.
Once again, it would be better if Parser had a public method for extracting a method header, one that TPureBehavior could safely rely on.

Attached Files

Relationships

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
04-04-06 00:30	nicolas cellier	New Issue
04-04-06 00:30	nicolas cellier	Status	new => assigned
04-04-06 00:30	nicolas cellier	Assigned To	=> dvf

Mantis 1.0.8[^]

30 total queries executed.
27 unique queries executed.