Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0003426 [Squeak] Kernel minor N/A 04-04-06 22:13 04-18-10 22:05
Reporter nicolas cellier View Status public  
Assigned To nicolas cellier
Priority normal Resolution fixed  
Status closed   Product Version 3.9
Summary 0003426: init: method should be renamed initialize: for consistency
Description Pure indexable class implement new: as
    (self basicNew: n) initialize

And indexable-like (not declared as variableSubclass) do:
    (self basicNew) initialize: n

Except SharedQueue and Set and sons which do:
    (self basicNew) init: n

So i renamed the #init: method into #initialize: for consistency and uniformity
Additional Information
Attached Files  Kernel-initMethodCleanUp.1.cs [^] (1,697 bytes) 04-04-06 22:13

- Relationships

- Notes
(0004680 - 353 - 513 - 513 - 513 - 513 - 513)
nicolas cellier
04-04-06 23:37

Most #new: implementations can be factored in a single place:
Simply test for the behavior being indexable or not
and send one of the two initialize path:

Behavior>>new: n
    ^self isVariable
        ifTrue: [(self basicNew: n) initialize]
        ifFalse: [self basicNew initialize: n]

This costs only an additional test at each creation...
 
(0004831 - 11 - 11 - 11 - 11 - 11 - 11)
ducasse
04-30-06 20:33

in 39a-7027
 
(0004843 - 61 - 61 - 61 - 61 - 61 - 61)
ducasse
05-02-06 20:55

This change blocks Squeak completely when MC started to clean
 
(0013296 - 31 - 31 - 31 - 31 - 31 - 31)
nicolas cellier
09-05-09 14:00

This has been integrated in 3.9
 

- Issue History
Date Modified Username Field Change
04-04-06 22:13 nicolas cellier New Issue
04-04-06 22:13 nicolas cellier File Added: Kernel-initMethodCleanUp.1.cs
04-04-06 23:37 nicolas cellier Note Added: 0004680
04-30-06 20:33 ducasse Status new => closed
04-30-06 20:33 ducasse Note Added: 0004831
04-30-06 20:33 ducasse Resolution open => fixed
05-02-06 20:55 ducasse Status closed => feedback
05-02-06 20:55 ducasse Resolution fixed => reopened
05-02-06 20:55 ducasse Note Added: 0004843
09-05-09 14:00 nicolas cellier Status feedback => resolved
09-05-09 14:00 nicolas cellier Fixed in Version  => 3.9
09-05-09 14:00 nicolas cellier Resolution reopened => fixed
09-05-09 14:00 nicolas cellier Assigned To  => nicolas cellier
09-05-09 14:00 nicolas cellier Note Added: 0013296
04-18-10 22:05 andreas Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
56 total queries executed.
38 unique queries executed.
Powered by Mantis Bugtracker