Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0003434 [Squeak] System major always 04-06-06 00:10 07-20-06 10:45
Reporter andreas View Status public  
Assigned To
Priority normal Resolution fixed  
Status closed   Product Version
Summary 0003434: Smalltalk condenseSources broken
Description Needs the attached fix, but beware of 0003433
Additional Information
Attached Files  CondenseSources.1.cs [^] (1,996 bytes) 04-06-06 00:11

- Relationships
related to 0003433closed MarcusDenker MultiByteFileStream screws up default text converter if file name = sources name 

- Notes
(0004829 - 140 - 176 - 176 - 176 - 176 - 176)
ducasse
04-30-06 19:25

Hi andreas

what do you mean exactly?
that this is a fix for condense changes
but not really fix the deep root of the problem?

Stef
 
(0004830 - 2001 - 3299 - 3299 - 3299 - 3299 - 3299)
ducasse
04-30-06 19:33

Hi
I checked with the 39.7025 code and the 39 code takes into account the traits in the process.
Beside that I do not see the difference (I should check in 3.8 to see the changes).

Here is the 3.9 code

condenseSources
    "Move all the changes onto a compacted sources file."
    "Smalltalk condenseSources"

    | f dir newVersionString count |
    Utilities fixUpProblemsWithAllCategory.
    "The above removes any concrete, spurious '-- all --' categories, which mess up the process."
    dir := FileDirectory default.
    newVersionString := UIManager default request: 'Please designate the version
for the new source code file...' initialAnswer: SmalltalkImage current sourceFileVersionString.
    newVersionString ifNil: [^ self].
    newVersionString = SmalltalkImage current sourceFileVersionString ifTrue:
        [^ self error: 'The new source file must not be the same as the old.'].
    SmalltalkImage current sourceFileVersionString: newVersionString.

    "Write all sources with fileIndex 1"
    f := FileStream newFileNamed: SmalltalkImage current sourcesName.
    f header; timeStamp.
'Condensing Sources File...'
    displayProgressAt: Sensor cursorPoint
    from: 0 to: self classNames size + self traitNames size
    during:
        [:bar | count := 0.
        Smalltalk allClassesAndTraitsDo:
            [:classOrTrait | bar value: (count := count + 1).
            classOrTrait fileOutOn: f moveSource: true toFile: 1]].
    f trailer; close.

    "Make a new empty changes file"
    SmalltalkImage current closeSourceFiles.
    dir rename: SmalltalkImage current changesName
        toBe: SmalltalkImage current changesName , '.old'.
    (FileStream newFileNamed: SmalltalkImage current changesName)
        header; timeStamp; close.
    SmalltalkImage current lastQuitLogPosition: 0.

    self setMacFileInfoOn: SmalltalkImage current changesName.
    self setMacFileInfoOn: SmalltalkImage current sourcesName.
    SmalltalkImage current openSourceFiles.
    self inform: 'Source files have been rewritten!
Check that all is well,
and then save/quit.'
 
(0004834 - 270 - 270 - 270 - 401 - 401 - 401)
andreas
05-01-06 00:30

I mean precisely what the subject says, namely that condenseSources is broken. There are/were two problems, one that requires the fix here the other one reported in 0003433. If you think it's been solved, just run condenseSources and if everythng is fine afterwards, good.
 
(0006107 - 58 - 58 - 58 - 58 - 58 - 58)
MarcusDenker
07-20-06 10:45

this (SmalltalkImage vs. Smalltalk) has already been fixed
 

- Issue History
Date Modified Username Field Change
04-06-06 00:10 andreas New Issue
04-06-06 00:11 andreas File Added: CondenseSources.1.cs
04-06-06 00:12 andreas Relationship added related to 0003433
04-30-06 19:25 ducasse Note Added: 0004829
04-30-06 19:33 ducasse Note Added: 0004830
05-01-06 00:30 andreas Note Added: 0004834
07-20-06 10:45 MarcusDenker Status new => closed
07-20-06 10:45 MarcusDenker Note Added: 0006107
07-20-06 10:45 MarcusDenker Resolution open => fixed
07-20-06 10:45 MarcusDenker Fixed in Version  => 3.9


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
55 total queries executed.
39 unique queries executed.
Powered by Mantis Bugtracker