0003458: PositionableStream>>copyPreamble:from:at: broken

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003458

[Squeak 3.8] Kernel

major

always

04-11-06 23:01

04-25-06 14:22

Reporter

andreas

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Summary

0003458: PositionableStream>>copyPreamble:from:at: broken

Description

PositionableStream>>copyPreamble:from:at: uses the last occurance of the string "stamp:" in the 50-100 bytes before the source position to find the time stamp for a method. This will fail if the previous method uses the word "stamp:" and the current method doesn't actually have a time stamp. Observed (for example) in a setting where ClassDescription was moved in condenseSources and the input data looked like here:

' onFileNumber: 2 toFile: aFileStream) stamp: aStamp! !

!ClassDescription methodsFor: ''fileIn/Out''!
'

In the above, the first part is the last portion of ClassDescription>>putClassCommentToCondensedChangesFile: and the second part the actual preamble of ClassDescription>>reformatAll. Other places are affected by this issue as well in particular after condensing changes or sources.

Additional Information

Attached Files

PositionableStream-copyPreamblefromat.st [^] (1,074 bytes) 04-12-06 01:45

Relationships

Notes
(0004736 - 69 - 69 - 69 - 69 - 69 - 69) andreas 04-12-06 01:45	The attached fix uses #backChunk to determine the preamble correctly.

(0004800 - 13 - 13 - 13 - 13 - 13 - 13) MarcusDenker 04-25-06 14:22	added to 7025

Issue History
Date Modified	Username	Field	Change
04-11-06 23:01	andreas	New Issue
04-12-06 01:45	andreas	File Added: PositionableStream-copyPreamblefromat.st
04-12-06 01:45	andreas	Note Added: 0004736
04-25-06 14:22	MarcusDenker	Note Added: 0004800
04-25-06 14:22	MarcusDenker	Project	Squeak => Squeak 3.8

Mantis 1.0.8[^]

39 total queries executed.
30 unique queries executed.