0003491: Running a class test case pollutes changes log with #defaultAction

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003491

[Squeak 3.8] Tools

minor

always

04-21-06 18:34

04-25-06 14:23

Reporter

black

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Summary

0003491: Running a class test case pollutes changes log with #defaultAction

Description

The method ClassTestCase >> #resumeFromDeprecatedMethods: recompiles or demoves Deprecation >> #defaultAction. This pollutes the current change set. This bug may only manifest itself if the preference showDeprecationWarnings is off.

resumeFromDeprecatedMethods: autoResume
    "If true, make the default action for all Deprecation warnings to resume"

    | da |
    autoResume
        ifTrue: [Deprecation compiledMethodAt: #defaultAction ifAbsent:
                    [ Deprecation
                        addSelector: #defaultAction
                        withMethod: (Notification >> #defaultAction) ] ]
        ifFalse: [da _ Deprecation compiledMethodAt: #defaultAction ifAbsent: [].
                da == (Notification >> #defaultAction)
                    ifTrue: [ Deprecation basicRemoveSelector: #defaultAction] ]

Additional Information

I'm not clear if the right fix here is to turn off event reporting during the recompile, or to avoid the recompile altogether (by testing autoresume in the defaultAction?). Someone who knows about the deprecation machinery ought to look at this.

Attached Files

Relationships

Notes
(0004801 - 107 - 107 - 107 - 107 - 107 - 107) MarcusDenker 04-25-06 14:23	I fixed that in 3.9 by removing the drecation - disable/enable stuff... I move the report to the 3.8 mantis

Issue History
Date Modified	Username	Field	Change
04-21-06 18:34	black	New Issue
04-25-06 14:23	MarcusDenker	Note Added: 0004801
04-25-06 14:23	MarcusDenker	Project	Squeak => Squeak 3.8

Mantis 1.0.8[^]

33 total queries executed.
28 unique queries executed.