Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0003691 [Squeak] FFI minor always 05-21-06 22:05 07-12-06 20:49
Reporter nicolas cellier View Status public  
Assigned To andreas
Priority normal Resolution fixed  
Status closed   Product Version 3.9
Summary 0003691: [BUG][FIX] ExternalType>>storeOn: infinite loop
Description
Try:
    Transcript open.
    ExternalType long storeOn: Transcript.
    Transcript endEntry.
Additional Information
storeOn; is used in LiteralNode printOn:

I implemented FFI call with more than 15 args as:
    (pushConstant: 0; pushTemp: 0; send: #invokeWithArguments: )
where temp0 is an array of arguments.

Unfortunately, the debugger has a hard time due to above infinite loop.
Attached Files  FFI-ExternalType-storeOn-Patch.1.cs [^] (529 bytes) 05-21-06 22:10

- Relationships

- Notes
(0005022 - 339 - 425 - 425 - 425 - 425 - 425)
andreas
05-21-06 22:14

That's not a bug in the FFI - storeOn: generally does not deal with recursive structures like here:
  a1 := Array new: 1.
  a2 := Array new: 1.
  a1 at: 1 put: a2.
  a2 at: 1 put: a1.
  a1 storeString.
storeOn: is generally a fairly useless method unless the exact context of the operation is known beforehand. Use #printOn: instead.
 
(0005023 - 229 - 247 - 247 - 247 - 247 - 247)
nicolas cellier
05-21-06 22:29

I do agree, personnally i will not use storeOn:
BUT: the debugger does use storeOn: via LiteralNode...

The bug does not show on a regular image, that's true, but it does in a hacked image where 15 args limitation is resolved.
 
(0005024 - 47 - 47 - 47 - 47 - 47 - 47)
andreas
05-21-06 22:41

Well, if you have a solution, please submit it.
 
(0005411 - 102 - 102 - 228 - 228 - 228 - 228)
nicolas cellier
06-28-06 19:34

You can find my proposed solution for more than 15 arguments at http://bugs.impara.de/view.php?id=2918 [^]
 
(0005649 - 29 - 29 - 29 - 29 - 29 - 29)
andreas
07-09-06 03:46

Included. Thanks for the fix.
 

- Issue History
Date Modified Username Field Change
05-21-06 22:05 nicolas cellier New Issue
05-21-06 22:05 nicolas cellier Status new => assigned
05-21-06 22:05 nicolas cellier Assigned To  => andreas
05-21-06 22:10 nicolas cellier File Added: FFI-ExternalType-storeOn-Patch.1.cs
05-21-06 22:14 andreas Status assigned => resolved
05-21-06 22:14 andreas Resolution open => no change required
05-21-06 22:14 andreas Note Added: 0005022
05-21-06 22:29 nicolas cellier Status resolved => feedback
05-21-06 22:29 nicolas cellier Resolution no change required => reopened
05-21-06 22:29 nicolas cellier Note Added: 0005023
05-21-06 22:41 andreas Note Added: 0005024
06-28-06 19:34 nicolas cellier Note Added: 0005411
07-09-06 03:46 andreas Status feedback => resolved
07-09-06 03:46 andreas Resolution reopened => fixed
07-09-06 03:46 andreas Note Added: 0005649
07-12-06 20:49 MarcusDenker Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
60 total queries executed.
39 unique queries executed.
Powered by Mantis Bugtracker