0003709: Fix for TileMorphTest >>#testSoundTile

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003709

[Squeak] Morphic

minor

always

05-24-06 06:51

07-12-06 22:22

Reporter

View Status

public

Assigned To

Priority

normal

Resolution

fixed

Status

closed

Product Version

3.9

Summary

0003709: Fix for TileMorphTest >>#testSoundTile

Description

In 3.9b-7032 TileMorphTest>>#testSoundTile fails because it sends arrowAction: 1 and then expects the codeString ('silence') but in this version codeString returns another sound name.
I have never used TileMorph but looking in the code, I guess that the intention of the test was that after #arrowAction: 1 (1 is a delta), the next #soundChoice has to be the #literal of the TileMorph.
So I changed the test from:

testSoundTile
    "self debug: #testSoundTile"
    | tile dummy |
    dummy _ Morph new.
    tile _ SoundTile new literal: 'croak'.
    dummy addMorph: tile.
    tile arrowAction: 1.
    self assert: tile codeString = '(''silence'')'.

to:

testSoundTile

    | tile dummy expectedCodeString |

    dummy := Morph new.
    tile := SoundTile new.
    tile literal: tile soundChoices first.
    dummy addMorph: tile.
    tile arrowAction: 1.
    expectedCodeString := '(', tile soundChoices second printString, ')'.

    self assert: tile codeString = expectedCodeString
        description: '#codeString should be the next sound choice'

Additional Information

Attached Files

MorphicTestFixes.1.cs [^] (530 bytes) 05-24-06 06:51

Relationships

Notes
(0005815 - 5 - 5 - 5 - 5 - 5 - 5) MarcusDenker 07-12-06 22:22	added

Issue History
Date Modified	Username	Field	Change
05-24-06 06:51	DF	New Issue
05-24-06 06:51	DF	File Added: MorphicTestFixes.1.cs
05-24-06 07:13	DF	Issue Monitored: DF
07-12-06 22:22	MarcusDenker	Status	new => closed
07-12-06 22:22	MarcusDenker	Note Added: 0005815
07-12-06 22:22	MarcusDenker	Resolution	open => fixed
07-12-06 22:22	MarcusDenker	Fixed in Version	=> 3.9

Mantis 1.0.8[^]

39 total queries executed.
30 unique queries executed.