0003773: Monticello Configuration Update From Repository Broken On More then One dash -

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0003773

[Squeak] Monticello

minor

always

06-05-06 14:57

Reporter

Ron

View Status

public

Assigned To

avi

Priority

normal

Resolution

open

Status

assigned

Product Version

3.9

Summary

0003773: Monticello Configuration Update From Repository Broken On More then One dash -

Description

If you have a version name that has more then one dash, the update from repository doesn't work. The reason is that the version name will not match the package name copy upto last $- since packages only have 1 dash max. The following change fixes the problem.

========================================================================

MCConfiguration>>updateFromRepositories
    | oldInfos newNames sortedNames newDeps |
    oldInfos _ self dependencies collect: [:dep | dep versionInfo].
    newNames _ Dictionary new.
    self repositories
        do: [:repo |
            ProgressNotification signal: '' extra: 'Checking ', repo description.
            (repo possiblyNewerVersionsOfAnyOf: oldInfos)
                do: [:newName | newNames at: newName put: repo]]
        displayingProgress: 'Searching new versions'.

    sortedNames _ newNames keys asSortedCollection:
        [:a :b | a numericSuffix > b numericSuffix].

    newDeps _ OrderedCollection new.
    self dependencies do: [:dep |
        | newName |
        newName _ sortedNames
            detect: [:each | (each copyUpToLast: $-) = (dep versionInfo name copyUpToLast: $-)]
            ifNone: [nil].
        newDeps add: (newName
            ifNil: [dep]
            ifNotNil: [
                | repo ver |
                repo _ newNames at: newName.
                ver _ self versionNamed: newName for: dep from: repo.
                ver ifNil: [dep]
                    ifNotNil: [MCVersionDependency package: ver package info: ver info]
            ])
    ] displayingProgress: 'downloading new versions'.

    self dependencies: newDeps.

========================================================================

The fix is match on version info instead the above method was changed as follows:

newName _ sortedNames
            detect: [:each | (each copyUpToLast: $-) = (dep versionInfo name copyUpToLast: $-)]

from:

newName _ sortedNames
            detect: [:each | (each copyUpToLast: $-) = dep package name]

Ron Teitelbaum
Ron@USMedRec.com

Additional Information

Attached Files

MCConfiguration-updateFromRepositories.st [^] (1,232 bytes) 06-05-06 14:57

Relationships

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
06-05-06 14:57	Ron	New Issue
06-05-06 14:57	Ron	Status	new => assigned
06-05-06 14:57	Ron	Assigned To	=> avi
06-05-06 14:57	Ron	File Added: MCConfiguration-updateFromRepositories.st

Mantis 1.0.8[^]

32 total queries executed.
27 unique queries executed.