Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004372 [Squeak] Morphic minor always 08-02-06 22:51 09-09-08 15:47
Reporter nicolas cellier View Status public  
Assigned To
Priority normal Resolution fixed  
Status closed   Product Version 3.10
Summary 0004372: PageUp and PageDown keys do not work in PluggableListMorph
Description Sometimes they move selection by 1. Sometimes they move selection by 0.
Try for example in a Browser...
Additional Information This bug is related to (introduced by?):
http://bugs.impara.de/bug_view_advanced_page.php?bug_id=1616 [^]

PluggableListMorph does not implement numSelectionsInView (as ListView does) and revert to ScrollPane default implementation:

numSelectionsInView
    "Answer the scroller's height based on the average number of submorphs."
    
    ^scroller numberOfItemsPotentiallyInView

numberOfItemsPotentiallyInView
    "Answer the number of items that could potentially be viewed in full,
    computed as my visible height divided by the average height of my submorphs.
    Ignore visibility of submorphs."

    ^self innerBounds height // (self localSubmorphBounds height / submorphs size)

Well, the scroller has a single submorph... this implementation is completely broken.
Attached Files

- Relationships
child of 0004719closed  [BUG][FIX] PageUp/PageDown works again in 3.9 

- Notes
(0006298 - 270 - 397 - 397 - 397 - 397 - 397)
nicolas cellier
08-02-06 23:03

Maybe code should be something like:

PluggableListMorph>>numSelectionsInView
    "Answer number of items that can fit in the view bounds."
    
    ^self bounds height // self listMorph font height

But maybe, this has not enough generality, i don't know enough of morphs
 
(0007057 - 60 - 60 - 186 - 186 - 186 - 186)
nicolas cellier
09-11-06 12:26

A [FIX]is proposed at http://bugs.impara.de/view.php?id=4719 [^]
 
(0010701 - 48 - 48 - 48 - 48 - 48 - 48)
edgardec
05-11-07 11:32

7091PluggableListMorphfix.cs solves this in 3.10
 
(0012610 - 63 - 63 - 63 - 159 - 159 - 159)
KenCausey
09-09-08 15:47

Fixed by 0004719 harvested with update 7091 and released in 3.10.
 

- Issue History
Date Modified Username Field Change
08-02-06 22:51 nicolas cellier New Issue
08-02-06 23:03 nicolas cellier Note Added: 0006298
09-11-06 12:26 nicolas cellier Note Added: 0007057
04-18-07 00:05 wiz Relationship added child of 0004719
04-18-07 08:58 edgardec Status new => feedback
04-18-07 08:58 edgardec Resolution open => reopened
04-18-07 08:58 edgardec version 3.9 => 3.10
05-11-07 11:32 edgardec Note Added: 0010701
05-11-07 11:33 edgardec Status feedback => resolved
08-11-07 23:12 matthewf Issue Monitored: matthewf
08-22-07 03:40 matthewf Issue End Monitor: matthewf
09-09-08 15:47 KenCausey Status resolved => closed
09-09-08 15:47 KenCausey Note Added: 0012610
09-09-08 15:47 KenCausey Resolution reopened => fixed
09-09-08 15:47 KenCausey Fixed in Version  => 3.10


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
64 total queries executed.
42 unique queries executed.
Powered by Mantis Bugtracker