Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004609 [Squeak] Morphic minor always 08-20-06 00:47 04-18-10 22:07
Reporter wiz View Status public  
Assigned To wiz
Priority normal Resolution fixed  
Status closed   Product Version 3.9
Summary 0004609: [Fix] Removal of ButtonPropertiesMorph left an unimplemented call.
Description The bug fix for Mantis 0000521 was the removal of ButtonPropertiesMorph

Current work on Mantis 0004544 shows that
AlignmentMorphBob1 called a method that was only implemented in the
ButtonPropertiesMorph.

 
Additional Information The two removed routines are here so other eyes than mine can see.:

ButtonPropertiesMorph>>
acceptDroppingMorph: aMorph event: evt

    | handlerForDrops |

    handlerForDrops _ self valueOfProperty: #handlerForDrops ifAbsent: [
        ^super acceptDroppingMorph: aMorph event: evt
    ].
    (handlerForDrops acceptDroppingMorph: aMorph event: evt in: self) ifFalse: [
        aMorph rejectDropMorphEvent: evt. "send it back where it came from"
    ].

ButtonPropertiesMorph>>
wantsDroppedMorph: aMorph event: evt

    | handlerForDrops |

    handlerForDrops _ self valueOfProperty: #handlerForDrops ifAbsent: [
        ^super wantsDroppedMorph: aMorph event: evt
    ].
    ^handlerForDrops wantsDroppedMorph: aMorph event: evt in: self

BPMCleanup-wiz.1.cs removes them.

Yours in service, -- Jerome Peace
Attached Files  BPMCleanup-wiz.1.cs [^] (759 bytes) 08-20-06 00:47
 7054 - 6665unimpAnnotedA-H.text [^] (3,382 bytes) 08-20-06 02:08

- Relationships
child of 0004544closed  In 7054 there are 194 unimplementedCalls including some that look like they might be important 

- Notes
(0008311 - 47 - 57 - 57 - 57 - 57 - 57)
RalphJohnson
11-18-06 01:28

Shouldn't the resolution be changed to "fixed"?
 
(0008318 - 474 - 534 - 534 - 534 - 534 - 534)
wiz
11-18-06 08:39

Hi Ralph,

In general reporters don't have access to change the report status.

I enjoy the lack of authority or responsibility. Someone else needs to look at, judge, and bless the fix. That is a first guard for quality.

Sooner or later someone will get back into harvesting mode and update the status when they choose to harvest the fix. Till then it sits here as just a suggestion.

Though I take your comment as a compliment.

Yours in service, -Jerome Peace
 

- Issue History
Date Modified Username Field Change
08-20-06 00:47 wiz New Issue
08-20-06 00:47 wiz File Added: BPMCleanup-wiz.1.cs
08-20-06 02:08 wiz File Added: 7054 - 6665unimpAnnotedA-H.text
11-18-06 01:28 RalphJohnson Note Added: 0008311
11-18-06 08:39 wiz Note Added: 0008318
01-20-07 05:53 wiz Assigned To  => wiz
01-20-07 05:53 wiz Status new => assigned
01-20-07 05:53 wiz Resolution open => fixed
01-20-07 05:53 wiz Relationship added child of 0004544
09-20-07 02:48 wiz Status assigned => resolved
09-20-07 02:48 wiz Fixed in Version  => 3.10
04-18-10 22:07 andreas Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
54 total queries executed.
38 unique queries executed.
Powered by Mantis Bugtracker