Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0004814 [Squeak] Kernel minor always 09-09-06 16:32 09-30-13 23:14
Reporter Krivanek View Status public  
Assigned To tim
Priority normal Resolution fixed  
Status closed   Product Version 3.10
Summary 0004814: [KernelImageOverride] MultiCompositionScanner setFont
Description MultiCompositionScanner >> setFont

original:

setFont
    super setFont.
    breakAtSpace _ false.
    wantsColumnBreaks == true ifTrue: [
        stopConditions _ stopConditions copy.
        stopConditions at: TextComposer characterForColumnBreak asciiValue + 1 put: #columnBreak.
    ].

override:

setFont
    super setFont.
    breakAtSpace := false.
    wantsColumnBreaks == true ifTrue: [
        stopConditions := stopConditions copy.
        stopConditions at: 12 + 1 put: #columnBreak.
    ].

dependent classes are not present in KI so fixed numbers were used
Additional Information
Attached Files

- Relationships

- Notes
(0007029 - 30 - 30 - 30 - 30 - 30 - 30)
Krivanek
09-09-06 18:06

the same in CompositionScanner
 
(0007040 - 250 - 268 - 268 - 268 - 268 - 268)
kwl
09-10-06 10:54

I suggest to move #characterForColumnBreak to class Character, where everybody can use it (and it is shared if some non-kernel package needs that value).

So instead TextComposer characterForColumnBreak
we'd have Character characterForColumnBreak.
 
(0014458 - 354 - 378 - 378 - 378 - 378 - 378)
tim
09-30-13 23:13

It's ridiculous to have TextComposer maintaining a Character constant.
Added it to Character, change TextComposer to delegate it, changed senders to use Character version.
Collections-tpr.537 Author: tpr Time: 30 September 2013
Name: Graphics-tpr.241 Author: tpr Time: 30 September 2013
Name: MorphicExtras-tpr.120 Author: tpr Time: 30 September 2013
 
(0014459 - 72 - 75 - 75 - 75 - 75 - 75)
tim
09-30-13 23:14

TextComposer class>characterForColumnBreak should be deprecated sometime
 

- Issue History
Date Modified Username Field Change
09-09-06 16:32 Krivanek New Issue
09-09-06 18:06 Krivanek Note Added: 0007029
09-10-06 10:54 kwl Note Added: 0007040
09-30-13 23:06 tim Status new => assigned
09-30-13 23:06 tim Assigned To  => tim
09-30-13 23:13 tim Note Added: 0014458
09-30-13 23:14 tim Status assigned => resolved
09-30-13 23:14 tim Fixed in Version  => 4.4
09-30-13 23:14 tim Resolution open => fixed
09-30-13 23:14 tim Note Added: 0014459
09-30-13 23:14 tim Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
51 total queries executed.
38 unique queries executed.
Powered by Mantis Bugtracker